Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages and logging in Charon when processing validator exits #3136

Open
5 tasks done
boulder225 opened this issue Jun 12, 2024 · 2 comments
Open
5 tasks done

Improve error messages and logging in Charon when processing validator exits #3136

boulder225 opened this issue Jun 12, 2024 · 2 comments
Assignees
@KaloyanTanev
Labels
protocol Protocol Team tickets

Comments

@boulder225
Copy link

boulder225 commented Jun 12, 2024 •
edited by KaloyanTanev
Loading

🎯 Problem to be solved

When processing validator exits, Charon's error messages and logging do not provide enough detail to easily identify the specific causes of failures. This makes it difficult for developers to diagnose and resolve issues.

🛠️ Proposed solution

  • Review the current error handling and logging code paths related to processing validator exits
  • Update error messages to include relevant details such as validator IDs, error codes, or other contextual info
  • Add logging statements to capture important state or inputs/outputs at different steps of the exit process
  • Test changes by intentionally triggering various exit failure scenario
  • Update relevant documentation or runbooks
@github-actions github-actions bot added the protocol Protocol Team tickets label Jun 12, 2024
@boulder225
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @gsora @KaloyanTanev

@boulder225
Copy link
Author

Please add your planning poker estimate with Zenhub @LukeHackett12

@boulder225 boulder225 added candidate candidate for next sprint next-sprint-candidate and removed candidate candidate for next sprint next-sprint-candidate labels Sep 10, 2024
@KaloyanTanev KaloyanTanev self-assigned this Sep 12, 2024
@KaloyanTanev KaloyanTanev mentioned this issue Oct 23, 2024
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 28, 2024
@KaloyanTanev
*: improve logging and error handling for exits (#3347)
45c1ef5 
Add more logging and more detailed errors for exits. Given that the exits are fire and forget operation and not a long running process, we can afford more details without the issue of polluting with too much.

category: feature
ticket: #3136
KaloyanTanev added a commit that referenced this issue Nov 19, 2024
@KaloyanTanev
*: improve logging and error handling for exits (#3347)
c4c3557 
Add more logging and more detailed errors for exits. Given that the exits are fire and forget operation and not a long running process, we can afford more details without the issue of polluting with too much.

category: feature
ticket: #3136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaloyanTanev KaloyanTanev

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KaloyanTanev @boulder225