Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Exit Message are compliant with EIP-7044 #2981

Closed
2 tasks
boulder225 opened this issue Mar 19, 2024 · 1 comment · Fixed by #3035
Closed
2 tasks

Ensure Exit Message are compliant with EIP-7044 #2981

boulder225 opened this issue Mar 19, 2024 · 1 comment · Fixed by #3035
Assignees
Labels
protocol Protocol Team tickets V1

Comments

@boulder225
Copy link

🎯 Problem to be solved

EIP-7044 mandates exit messages to be signed on Capella's domain. In Charon, exit messages aren't signed, but their validity is verified, typically using the last available domain. It's crucial to ensure the domain from Capella is used for this purpose.

🛠️ Proposed solution

  • Implement a mechanism to identify and use Capella's domain for signing exit messages in compliance with EIP-7044.
  • Update the validity verification process in Charon to prioritize Capella's domain when checking exit messages.
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 19, 2024
@boulder225 boulder225 added the V1 label Mar 19, 2024
@boulder225
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @gsora @pinebit @KaloyanTanev

obol-bulldozer bot pushed a commit that referenced this issue Apr 12, 2024
Instead of returning the latest Domain available when the DomainName requested is VOLUNTARY_EXIT, returns the Capella one as detailed in EIP-7044.

Doing so fixes both `exit` commands generating wrong signatures and voluntary exits sent over the VC.

category: bug
ticket: #2981

Closes #2981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets V1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants