Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEV rewards sent to addresses configured on the CL + VC before key splitting, not as specified in Charon's lock file #2770

Closed
3 of 4 tasks
boulder225 opened this issue Jan 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working protocol Protocol Team tickets

Comments

@boulder225
Copy link

boulder225 commented Jan 8, 2024

🎯 Problem to be solved

Reports from two clusters indicate that MEV rewards are being sent to addresses configured on the CL + VC, not as specified in Charon's lock file. Validator keys previously operated solo are now part of a split and are experiencing issues with MEV reward distribution. The core of the problem seems to be related to timestamp discrepancies between Charon's builder registration (set to the genesis timestamp) and the timestamp used during the solo operation of these validators.

Problem identified

The timestamps on the builder registration while as a solo were greater than the genesis timestamp used by charon create cluster --split-existing-keys and thus took precedence

🛠️ Proposed solution

  • Investigate the timestamp configuration in both the Charon cluster lock and the solo operation setups to understand the cause of the discrepancy.
  • Modify the code for --split-existing-keys to use the current timestamp for pre-generated builder registration instead of the genesis timestamp.
  • Document in a 'migration of a solo validator' page, that they need to turn off their mev-boost before they split keys to not run into this problem.

Future work

  • If we add charon support to talk to a relay directly, have charon poll the /relay/v1/data/validator_registration endpoint to confirm if the MEV reward distribution matches the lock file settings, and mark charon as unhealthy if not.
@github-actions github-actions bot added the protocol Protocol Team tickets label Jan 8, 2024
@OisinKyne OisinKyne added bug Something isn't working and removed bug Something isn't working labels Jan 16, 2024
obol-bulldozer bot pushed a commit that referenced this issue Jan 22, 2024
Use the current timestamp for builder registration messages when using `--split-existing-keys` mode.

See [the issue](#2770) for the full context.

category: bug
ticket: #2770
gsora pushed a commit that referenced this issue Feb 21, 2024
Use the current timestamp for builder registration messages when using `--split-existing-keys` mode.

See [the issue](#2770) for the full context.

category: bug
ticket: #2770
obol-bulldozer bot pushed a commit that referenced this issue Feb 21, 2024
Cherrypick of #2810 

---

Use the current timestamp for builder registration messages when using `--split-existing-keys` mode.

See [the issue](#2770) for the full context.

category: bug
ticket: #2770
@OisinKyne OisinKyne changed the title MEV rewards sent to addresses configured on the CL + VC, not as specified in Charon's lock file MEV rewards sent to addresses configured on the CL + VC before key splitting, not as specified in Charon's lock file Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

3 participants