Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track builder registrations with tracker #2669

Closed
3 tasks
dB2510 opened this issue Oct 31, 2023 · 0 comments
Closed
3 tasks

Track builder registrations with tracker #2669

dB2510 opened this issue Oct 31, 2023 · 0 comments
Assignees
Labels
protocol Protocol Team tickets v0.18.0

Comments

@dB2510
Copy link
Contributor

dB2510 commented Oct 31, 2023

🎯 Problem to be solved

We have two types of builder registrations, pre-generated registrations and registrations submitted by VC (using proposer config). Currently, we use core_bcast_broadcast_total metric to successful registrations on dashboard alongwith other duties. While we recently introduced these three metrics for better tracking of duties using tracker: core_tracker_success_duties_total, core_tracker_expect_duties_total and core_tracker_failed_duties_total.
We need to include builder_registration duty tracking in tracker so that we can use one set metrics to track all the duties. Tracker will help in analysing/reporting the reason behind the registrations failure.

🛠️ Proposed solution

Integrate recaster component to tracker to report builder_registration duty success and failures. It should also pass the error to tracker component to analyse the reason behind the failure.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Oct 31, 2023
@dB2510 dB2510 added the v0.18.0 label Oct 31, 2023
@dB2510 dB2510 self-assigned this Dec 12, 2023
obol-bulldozer bot pushed a commit that referenced this issue Dec 18, 2023
Wire recaster component in the Wire function of `interfaces.go` to integrate `DutyBuilderRegistration` to tracker. This will enable tracking of all the rebroadcast submissions by recaster.

category: feature
ticket: #2669
@dB2510 dB2510 closed this as completed Jan 16, 2024
@dB2510 dB2510 reopened this Jan 16, 2024
@dB2510 dB2510 closed this as completed Jan 16, 2024
obol-bulldozer bot pushed a commit that referenced this issue Feb 13, 2024
Reverts #2752 as it was not working as expected and was blocking registrations health checks changes.

category: misc
ticket: #2669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets v0.18.0
Projects
None yet
Development

No branches or pull requests

1 participant