Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing flags error on create cluster command #2444

Closed
HananINouman opened this issue Jul 18, 2023 · 0 comments · Fixed by #2445
Closed

Missing flags error on create cluster command #2444

HananINouman opened this issue Jul 18, 2023 · 0 comments · Fixed by #2445
Assignees
@gsora
Labels
bug Something isn't working protocol Protocol Team tickets

Comments

@HananINouman
Copy link
Contributor

HananINouman commented Jul 18, 2023 •
edited
Loading

🎯 Problem to be solved

create cluster command throws an error about missing --nodes, --num-validators flags when --definition-file is passed.

Image

🛠️ Proposed solution
@github-actions github-actions bot added the protocol Protocol Team tickets label Jul 18, 2023
@HananINouman HananINouman added the bug Something isn't working label Jul 18, 2023
@gsora gsora mentioned this issue Jul 18, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jul 26, 2023
@gsora
cmd: fix create cluster regression (#2445)
dc84c66 
After the `create cluster` refactor a couple PR's back, definition file was essentially ignored.

This PR restores that functionality back.

category: bug
ticket: #2444

Closes #2444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsora gsora

Labels
bug Something isn't working protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: fix create cluster regression ObolNetwork/charon
2 participants
@gsora @HananINouman