Tagged release versions not overwritten to app.Version. #2270
Comments
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jun 5, 2023
Prints the built version inside the docker file to debug incorrect tagged versions. category: misc ticket: #2270
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jun 5, 2023
Also use `-a` flag to force rebuild when setting `-ldflags` when overriding tagged versions. Since `-ldflags=-X path/to/package.Var=foo` contains a space inside the value, the only way I could get this to work is to provide it via an additional `GO_BUILD_FLAG_2` variable. The other option would be wrangling arrays and splitting using something like `IFS=' ' read -ra BUILD_ARGS <<< "$OPTIONAL_BUILD_ARGS"` but I feel this is more verbose but simpler to understand. category: misc ticket: #2270
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jun 5, 2023
Convert build args into env vars. category: misc ticket: #2270
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jun 5, 2023
Fixes the github action "build-push-deploys" `build-args` parameter. It is a [list parameter that is new line delimited](https://github.com/docker/build-push-action#inputs). Also remove `-a` build arg since it isn't required. Make it explicit that `GO_BUILD_FLAG` only supports a single flag. category: misc ticket: #2270
This was referenced Jul 28, 2023
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jul 28, 2023
Fixes the github action "build-push-deploys" `build-args` parameter. It is a [list parameter that is new line delimited](https://github.com/docker/build-push-action#inputs). Also remove `-a` build arg since it isn't required. Make it explicit that `GO_BUILD_FLAG` only supports a single flag. This ports the fix from `main-v0.16` release branch to main. category: misc ticket: #2270
xenowits
added a commit
that referenced
this issue
Jul 28, 2023
Fixes the github action "build-push-deploys" `build-args` parameter. It is a [list parameter that is new line delimited](https://github.com/docker/build-push-action#inputs). Also remove `-a` build arg since it isn't required. Make it explicit that `GO_BUILD_FLAG` only supports a single flag. This ports the fix from `main-v0.16` release branch to main. category: misc ticket: #2270
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jul 29, 2023
Fixes the github action "build-push-deploys" `build-args` parameter. It is a [list parameter that is new line delimited](https://github.com/docker/build-push-action#inputs). Also remove `-a` build arg since it isn't required. Make it explicit that `GO_BUILD_FLAG` only supports a single flag. This ports the fix from `main-v0.16` release branch to `main-v0.17`. category: misc ticket: #2270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Bug Report
Description
The
v0.16.0-rc1git taged docker image has incorrectapp.Version. The build and publish step didn't overwrite the variable tov0.16.0-rc1even though the theGO_BUILD_FLAGSwas populated correctly, it didn't work. Wonder if a previous cached version with used or something 🤔https://github.com/ObolNetwork/charon/actions/runs/5145269628/jobs/9262690170
Suggest commiting fix directly to release branch, testing it works (can only test on release branch), then cherry picking final fix to main (reverse order).
The text was updated successfully, but these errors were encountered: