Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect attestation inclusion check #2130

Closed
dB2510 opened this issue Apr 25, 2023 · 0 comments
Closed

Incorrect attestation inclusion check #2130

dB2510 opened this issue Apr 25, 2023 · 0 comments
Assignees
@corverroos
Labels
bug Something isn't working protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Apr 25, 2023 •
edited
Loading

🐞 Bug Report

Description

Seems like there is a bug in the way we calculated attestation inclusion in recent refactor of inclusion checker. Some of the attestation that are marked as never included on-chain were actually included in a block. Here are the logs from core team cluster node outrageous-taxi:
image

For example, check for first log slot number 5492676, here's our validator https://goerli.beaconcha.in/validator/0xafd55095b1390d6f075aaac8673bde501d9ec0459cc32b96ba311b4f36d47cf3b2dd846be3833260c92703c26f8c6423#attestations. It says our attestation was included in 5492677.

🔬 Minimal Reproduction

Run charon with tag 96af658.
@github-actions github-actions bot added the protocol Protocol Team tickets label Apr 25, 2023
@dB2510 dB2510 added the bug Something isn't working label Apr 26, 2023
@corverroos corverroos self-assigned this May 9, 2023
@corverroos corverroos mentioned this issue May 9, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 9, 2023
@corverroos
core/tracker: add inclusion missed debug logs (#2168)
15846f8 
Add debug logs to aid debugging false negative inclusion checks. 

category: bug
ticket: #2130
@corverroos corverroos mentioned this issue May 23, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 23, 2023
@corverroos
core/tracker: handle duplicate attestations per block (#2223)
ff3a0fc 
Fix inclusion tracker to handle duplicate attestations per block. That means attestations with identical attestation data, but  different aggregation bits. 

category: bug
ticket: #2130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
bug Something isn't working protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corverroos @dB2510