Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port geth eip-712 package #1698

Closed
corverroos opened this issue Jan 27, 2023 · 0 comments
Closed

Port geth eip-712 package #1698

corverroos opened this issue Jan 27, 2023 · 0 comments
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

Problem to be solved

One last feature from the geth dependency to remove is the eip-712 functionality: github.com/ethereum/go-ethereum/signer/core/apitypes

Proposed solution

Port code to eth2util.

Out of Scope

If there is anything to highlight as out of scope for this issue, please outline it here.
@github-actions github-actions bot added the protocol Protocol Team tickets label Jan 27, 2023
@corverroos corverroos mentioned this issue Jan 27, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 30, 2023
@corverroos
eth2util: implement basic eip712 package (#1707)
eb74d66 
Implements a basic EIP712 structured type data signing.

category: feature
ticket: #1698
@corverroos corverroos mentioned this issue Jan 30, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 30, 2023
@corverroos
gomod: remove geth dependency (#1710)
953b6f8 
Finally removes all traces of go-ethereum and the dependency.

category: refactor
ticket: #1698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corverroos @thomasheremans