Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKG smoke test shutdown race condition #1625

Closed
corverroos opened this issue Jan 13, 2023 · 1 comment
Closed

DKG smoke test shutdown race condition #1625

corverroos opened this issue Jan 13, 2023 · 1 comment
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

Problem to be solved

When DKG instances shutdown as part of compose, there is a race where the first DKG completes, which causes the container the exit, which causes the docker-compose to stop the other container, which can result in other DKG not completing properly by saving the artefacts to disk, see example.

Proposed solution

  • Docker-compose shouldn't terminate all containers when the first exits with 0, but rather wait for manual "down" command.
  • Add a hidden "wait for something signal" before exitting the DKG...?
@corverroos
Copy link
Contributor Author

dkg.log

@corverroos corverroos mentioned this issue Jan 17, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 18, 2023
@corverroos
testutil/compose: fix dkg shutdown race (#1647)
37363a1 
Sleep for 2 seconds after successful DKG completion to allow other DKGs to complete as well before exitting causing docker-compose to stop all other containers. This fixes shutdown race in compose DKG tests.

category: test
ticket: #1625
@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corverroos @thomasheremans