Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random panic bug #1389

Closed
xenowits opened this issue Nov 7, 2022 · 0 comments
Closed

Fix random panic bug #1389

xenowits opened this issue Nov 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@xenowits
Copy link
Contributor

xenowits commented Nov 7, 2022

🐞 Bug Report

Description

Random panic bugs are encountered when running smoke_internal_test.go. These panics are related to closing an already closed channel.

The error traces lead to SlotAttester's Prepare method and SyncComm's PrepareEpoch method.

Has this worked before in a previous version?

Yes.

🔬 Minimal Reproduction

Run "default beta" smoke test locally multiple times. Or perhaps run the test in a loop.

🔥 Error


1260052398-node2-1           | panic: close of closed channel
1260052398-node2-1           | 
1260052398-node2-1           | goroutine 461 [running]:
1260052398-node2-1           | github.com/obolnetwork/charon/testutil/validatormock.(*SyncCommMember).PrepareEpoch(0xc000137080, {0x1b23430, 0xc0002fc780})
1260052398-node2-1           | 	/Users/xenowits/obol/charon/testutil/validatormock/synccomm.go:130 +0x110
1260052398-node2-1           | github.com/obolnetwork/charon/app.wireValidatorMock.func1.2({0x1b23430?, 0xc0002fc780?}, {{0x1b3c8f0, 0xc001bf4760}, 0xc001d0a5a0, 0xc001ec7220, 0xc000137080})
1260052398-node2-1           | 	/Users/xenowits/obol/charon/app/vmock.go:59 +0x45
1260052398-node2-1           | github.com/obolnetwork/charon/app.newVMockWrapper.func1.1()
1260052398-node2-1           | 	/Users/xenowits/obol/charon/app/vmock.go:168 +0xac
1260052398-node2-1           | created by github.com/obolnetwork/charon/app.newVMockWrapper.func1
1260052398-node2-1           | 	/Users/xenowits/obol/charon/app/vmock.go:164 +0x5e5

🌍 Your Environment

Operating System:

  
macOS Monterey
Version 12.6
  

What version of Charon are you running? (Which release)

  
Locally built latest main
  

Anything else relevant (validator index / public key)?

@xenowits xenowits self-assigned this Nov 7, 2022
@xenowits xenowits added the bug Something isn't working label Nov 7, 2022
@xenowits xenowits removed their assignment Nov 7, 2022
obol-bulldozer bot pushed a commit that referenced this issue Nov 7, 2022
Fixes issues due to sporadic duplicate slot scheduling.  

category: bug
ticket: #1389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants