Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gitlab Enterprise integration #947

Closed
fdellwing opened this issue Apr 15, 2024 · 7 comments
Closed

Enable Gitlab Enterprise integration #947

fdellwing opened this issue Apr 15, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request version-2.3
Milestone

Comments

@fdellwing
Copy link

fdellwing commented Apr 15, 2024

Describe the bug:
I tried to setup Thread Dragon with Gitlab integration, but I don't get the button to use it. The documentation (https://owasp.org/www-project-threat-dragon/docs-2/development-environment/) does not help here.

Expected behaviour:
Having a working integration

Environment:

  • Version: 2.2.0
  • Platform: Web App
  • OS: Linux (docker compose)
  • Browser: Firefox

To Reproduce:

Any additional context, screenshots, etc:

services:
  threatdragon:
    image: owasp/threat-dragon:stable
    ports:
      - 127.0.0.1:3000:3000
    environment:
      ENCRYPTION_KEYS: '[{"isPrimary": true, "id": 0, "value": "12345678"}]'
      ENCRYPTION_JWT_SIGNING_KEY: '12345678'
      ENCRYPTION_JWT_REFRESH_SIGNING_KEY: '12345678'
      SERVER_API_PROTOCOL: 'http'
      GITLAB_APPLICATION_ID: 'super-secret'
      GITLAB_APPLICATION_SECRET: 'gloas-12345678'
      GITLAB_REDIRECT_URI: 'https://td.foobar.com/api/oauth/return'
      GITLAB_ENTERPRISE_HOSTNAME: 'gitlab.foobar.com'

grafik

grafik

@fdellwing fdellwing added the bug Something isn't working label Apr 15, 2024
@jgadsden
Copy link
Collaborator

we need a gitlab step-by-step similar to the BitBucket step-by-step and the github step-by-step

@jgadsden jgadsden added documentation Improvements or additions to documentation enhancement New feature or request and removed bug Something isn't working labels Apr 15, 2024
@fdellwing
Copy link
Author

Ok, I played with it a bit more, but it came to a crashing halt pretty fast:

threatdragon-1  | error: controllers/auth.js:  {"service":"threat-dragon","timestamp":"2024-04-15 12:43:40"}
threatdragon-1  | error: Gitlab Enterprise is not supported yet {"service":"threat-dragon","stack":"Error: Gitlab Enterprise is not supported yet\n    at getClient (/app/td.server/dist/repositories/gitlabrepo.js:29:11)\n    at Object.userAsync (/app/td.server/dist/repositories/gitlabrepo.js:88:10)\n    at _callee$ (/app/td.server/dist/providers/gitlab.js:99:23)\n    at tryCatch (/app/td.server/node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)\n    at Generator.<anonymous> (/app/td.server/node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)\n    at Generator.next (/app/td.server/node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)\n    at asyncGeneratorStep (/app/td.server/node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)\n    at _next (/app/td.server/node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:9)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","timestamp":"2024-04-15 12:43:40"}
threatdragon-1  | error: undefined {"service":"threat-dragon","timestamp":"2024-04-15 12:43:40"}

@jgadsden
Copy link
Collaborator

jgadsden commented Apr 15, 2024

ah, you are using GitLab Enterprise @fdellwing ? There is another thread on that in the slack channel, and @steve-winter may be submitting a pull request soon

@steve-winter
Copy link
Collaborator

I will get the PR pushed tomorrow. @fdellwing any assistance you can provide in testing would be appreciated.

@fdellwing
Copy link
Author

Sure, I'm happy to assist in testing.

@jgadsden
Copy link
Collaborator

thanks @steve-winter and @fdellwing for taking this on, I will assign the issue to you

@jgadsden jgadsden added this to the Version 2.3 milestone Apr 18, 2024
@jgadsden jgadsden changed the title Gitlab integration not working Enable Gitlab Enterprise integration Apr 27, 2024
@jgadsden jgadsden removed the documentation Improvements or additions to documentation label Apr 27, 2024
@fdellwing
Copy link
Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version-2.3
Projects
None yet
Development

No branches or pull requests

3 participants