Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Cannot find module .....demo-threat-model.json #262

Closed
lreading opened this issue Sep 9, 2021 · 2 comments · Fixed by #263
Closed

Windows: Cannot find module .....demo-threat-model.json #262

lreading opened this issue Sep 9, 2021 · 2 comments · Fixed by #263
Assignees
Labels
bug Something isn't working windows

Comments

@lreading
Copy link
Collaborator

lreading commented Sep 9, 2021

Describe the bug
On Windows using the executable on the release page for version 1.5.3, when clicking the "Get started by creating a completely new, empty threat model" or "Explore a sample model" option, an error message is shown saying that it cannot find module ../../ThreatDragonModels/new-model/new-model.json

You can still create a new model by navigating to File > New

This was graciously reported by our friend Simon.

Expected behaviour
A new model is created when clicking either option

Environment

  • Version: 1.5.3
  • Platform: Desktop App
  • OS: Windows (unknown version)

To Reproduce

  • Click "Get started by creating a completely new, empty threat model." OR "Explore a sample model. This is a good option if you are new to Threat Dragon"
  • An error is displayed

This seems to not affect the Linux snapcraft distribution. I did not see this behavior when testing on MacOS with the signed/notarized release either, though it may be worth another check in case I missed something.

@lreading lreading added bug Something isn't working windows labels Sep 9, 2021
@jgadsden
Copy link
Collaborator

jgadsden commented Sep 9, 2021

Ah, I know what has caused this and the fix is not too hard. Wish I had caught this before version 1.5.3 - all to do with consolidating the file set and shuffling files around , but then making sure it is cross-platform.

@lreading shall I take this on? I have a fix in mind

@jgadsden jgadsden self-assigned this Sep 9, 2021
@jgadsden
Copy link
Collaborator

jgadsden commented Sep 9, 2021

Having updated some code of mine, I realise that for some reason the threat model json files are not appearing in the windows installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants