Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Android version #37

Merged
merged 8 commits into from
Sep 19, 2022

Conversation

jsherm-fwdsec
Copy link
Collaborator

Upgraded Android version to 33, and migrated to AndroidX.

This PR closes #34.

@jsherm-fwdsec
Copy link
Collaborator Author

Hey @cpholguera. This seems to be failing checks because the build is failing on the "Sign app APK" step. I believe the keys might be misconfigured, because it builds fine in my fork: jsherm-fwdsec#2

@cpholguera
Copy link
Collaborator

Hi @jsherm-fwdsec, thanks for letting me know. When I merged your previous PR the Action was successful, so I assumed that the keys config was right. Please take a look here:

https://github.com/OWASP/MASTG-Hacking-Playground/actions/runs/3040311391

What do you think?

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you please remove and gitignore the whole ".idea" folder?

@jsherm-fwdsec
Copy link
Collaborator Author

Yeah it's really odd behaviour if the keys weren't purposely modified but I can't think of any other reason why. Can you possibly try resetting the keys? Check this out: r0adkll/sign-android-release#61

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @jsherm-fwdsec, I'll merge and we'll see if the signing works well from master. Thank you very much!

@cpholguera cpholguera merged commit 402f377 into OWASP:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the Kotlin App to the Latest Android Version
2 participants