Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug: Set InsecureSkipVerify=true for redisClient(operator) when u… #448

Closed

Conversation

muicoder
Copy link
Contributor

…sing TLS

Signed-off-by: muicoder [email protected]

Description

Fixes #447

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

Certificates: tlsClientCertificates,
ServerName: redisInfo.PodName,
RootCAs: tlsCaCertificates,
InsecureSkipVerify: true,

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@muicoder muicoder closed this Feb 23, 2023
@muicoder muicoder deleted the InsecureSkipVerify branch February 23, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using TLS, the operator cannot reconcile because TLS does not sign the pod name
1 participant