Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ping Time Duplicates #1382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ctuguinay
Copy link
Collaborator

Addresses the duplicate ping time part of #1374

@ctuguinay ctuguinay added bug Something isn't working data conversion labels Aug 27, 2024
@ctuguinay ctuguinay added this to the v0.9.1 milestone Aug 27, 2024
@ctuguinay ctuguinay self-assigned this Aug 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (9f56124) to head (bd443a4).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   83.52%   80.44%   -3.08%     
==========================================
  Files          64       18      -46     
  Lines        5686     3089    -2597     
==========================================
- Hits         4749     2485    -2264     
+ Misses        937      604     -333     
Flag Coverage Δ
unittests 80.44% <100.00%> (-3.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay marked this pull request as ready for review August 27, 2024 21:19
@ctuguinay ctuguinay requested a review from leewujung August 27, 2024 21:21
@ctuguinay
Copy link
Collaborator Author

@leewujung This should be ready for review

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctuguinay : Thanks for looking into this. I agree this would address the problem, but one thing I think we should check is if the entries with duplicated ping_time actually contain the same data. If not, the duplication of ping_time does not make sense, but dropping it would also mean that we lose data?

Also, the same as my comment on another PR, that if both files you used in the tests have the same issues, let's just keep one of them to avoid our test suite getting too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data conversion
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants