Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_mask dimension check should be agnostic of order of dimensions #1402

Open
leewujung opened this issue Oct 29, 2024 · 0 comments
Open
Labels
AA SI bug Something isn't working
Milestone

Comments

@leewujung
Copy link
Member

Currently the dimension check in apply_mask would check for matching dimension length and order for ping_time and depth (or range_sample). I've encountered the situation where the Sv or MVBS data being masked and the mask have the same length of the dimension but not the order. I think we can relax the order requirement since that is something that easily get altered depending on prior operations on these datasets.

@leewujung leewujung added the bug Something isn't working label Oct 29, 2024
@leewujung leewujung added this to the v0.9.1 milestone Oct 29, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AA SI bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant