Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Echo Range Scaling with Both Beam and Platform Angles (at the same time) #1324

Open
ctuguinay opened this issue May 30, 2024 · 1 comment
Assignees

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented May 30, 2024

From discussion of #1319 with @leewujung, I've limited the add_depth code to work with either Platform group angles or Beam group angles, but not both. The angles are currently being used to compute an echo range scaling factor, i.e., how much we should scale the original echo range values based on the total tilt of the transducer with respect to the z-axis.

The problem with incorporating both is that we do not know if the Platform group angles and the Beam group angles (at least for EK60/EK80) are coupled or decoupled, and the state of coupling will determine whether or not we can use them in conjunction with each other. Another way to phrase this is whether we can apply the Beam group angle rotations on top of the Platform group angle rotations, and vice versa. Currently, I am of the opinion that whether we can do these operations and receive valid results will be very dependent on the setup of the instruments involved in getting these angle measurements.

@ctuguinay ctuguinay added the data format Anything about data format label May 30, 2024
@ctuguinay ctuguinay added this to the v0.9.1 milestone May 30, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype May 30, 2024
@ctuguinay ctuguinay self-assigned this May 30, 2024
@ctuguinay ctuguinay changed the title Investigate Echo Range Scaling with Both Beam and Platform Angles Investigate Echo Range Scaling with Both Beam and Platform Angles (at the same time) May 30, 2024
@ctuguinay
Copy link
Collaborator Author

Note to self, would need to find data with non-NaN/non-0 Beam and Platform Angle data. When looking at the data test suite right now, I have yet to find a RAW file that has this property. Usually, it is just one of the groups having valid angle data. I'll leave this issue without a milestone and wait until a contributor has found a RAW file that has this property or a user has made a request for both groups' angle data to be used in echo_range_scaling.

@ctuguinay ctuguinay removed this from the v0.9.1 milestone Jun 3, 2024
@ctuguinay ctuguinay removed the data format Anything about data format label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant