Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Encore a completely offline experience #19

Open
0xRampey opened this issue Mar 20, 2017 · 2 comments
Open

Make Encore a completely offline experience #19

0xRampey opened this issue Mar 20, 2017 · 2 comments

Comments

@0xRampey
Copy link
Member

As of now, Encore makes network requests to unsplash.it for album art.
This has to be disabled for the time being as it delays loading of other page elements onsite.
Further information can be obtained by logging out of LDAP and checking out the Network section in Chrome Dev tools.

@kaivalyar
Copy link
Member

How do you propose we still display album art, in that case? have an offline repository of it? Have it transferred to our server the first time it gets downloaded by unsplash.it on the users machine?

@0xRampey
Copy link
Member Author

I think the better way is to parse songs for metadata before offloading them into the server. Also, keep a placeholder for the ones without album art. Maybe, we can also make the unsplash request asynchronous to prevent delays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants