Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Aid to health time series chart #54

Open
jm-rivera opened this issue Jan 16, 2023 · 0 comments
Open

Refactor: Aid to health time series chart #54

jm-rivera opened this issue Jan 16, 2023 · 0 comments
Assignees
Labels
enhancement Improve how something works

Comments

@jm-rivera
Copy link
Collaborator

Refactor aid to health time series chart. This and other charts rely on a function called id_to_sectors_ts, which must be refactored first, as covered in #53.

Refactoring the function here will involve filtering the right "health" sectors. You can continue to use the .filter_health_sectors function but check if there are any required improvements.

From there, you shouldn't need to change much.

https://github.com/ONEcampaign/aftershocks_data/blob/fb49e2558e727b3712935c0fd96e12c343415627/scripts/oda/overview_charts.py#LL218-L240

@jm-rivera jm-rivera added the enhancement Improve how something works label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve how something works
Projects
None yet
Development

No branches or pull requests

2 participants