Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion post list #215

Closed
BenGamma opened this issue Jan 11, 2019 · 37 comments
Closed

Discussion post list #215

BenGamma opened this issue Jan 11, 2019 · 37 comments
Labels
Frontend Wontfix This will not be worked on

Comments

@BenGamma
Copy link
Contributor

BenGamma commented Jan 11, 2019

We want to list all the posts available in the discussion section, e.g. mockup :

__Discussions_landing

Use the mocks data available in the mocks/mock.posts.tsx folder to get all the post.

child of #213

@chrismclarke
Copy link
Member

Again really like the mockups, I don't think we've implemented any sortable table structure yet so it might be a good place to start investigation (I think there probably is already material table or similar, and plenty of third party packages depending on how much we want them to be able to do... I would suggest simpler is better).

@BenGamma
Copy link
Contributor Author

I put this lib on the side a few weeks ago https://github.com/bvaughn/react-virtualized

It may be a bit overkill for what we want to do. Needs investigation.

@chrismclarke
Copy link
Member

I think we're planning to try and nail down the database structure this week and will update the mocks. I had assumed we'd be mostly creating our own implementation but happy to explore solutions that already exist. The link you sent looks really promising, @BenGamma you might want to take a look. I reviewed the licence and fine for our purposes (non-commercial, non-competitive)

@BenGamma
Copy link
Contributor Author

Yep looks promising, you can start an integration of this lib with our current mocks/mock.posts.tsx datas.
For the discussion replies it can also be an option, but as chris said we are working on the database structure this week and will create related issues when ready.
Good to ear that you have that much time to dedicate to the projet, will do our best to provide clear issues and goals !

@chrismclarke
Copy link
Member

I don't think there would be pictures associated with each discussion thread so that might not be worth too much effort, although I could imagine a toggle between grid and list being useful if it could also be reused on other components like the how tos perhaps.

@chrismclarke
Copy link
Member

Two of the next big pieces of work are implementing the tagging/filter system as well as search, I think that's where we could really implement some nice ways to help users find and engage with content easier

@BenGamma
Copy link
Contributor Author

@tx4x yes that's it ! we are working on the data structure right now, so consider that it will change in a close futur.

@chrismclarke
Copy link
Member

I really like it, seems like nice and flexible way to implement an advanced filter system. The other mechanism for filtering content will be through a generic 'search' box which will hook up to a search engine and provide deeper content searches and ranking algorithms. If you'd be interested in that feature also there's more info in #328

@chrismclarke
Copy link
Member

discussions backend updated (pull #332). @BenGamma , shouldn't require proper review (testing and working as intended, also fixed the simple filter system), but will require yarn install. Any more work on the list should be done taking the slightly changed structures into account (mostly just correcting the timestamp format).

@chrismclarke
Copy link
Member

plan to bind the create/edit workflow to the database tomorrow which should make it easier to create more substantial testing data (e.g. with correct tags, projects etc.) for use with filter system

@chrismclarke
Copy link
Member

the discussion backend is most advanced and refactors quite a bit of the discussions more generally, there's a pr open for review but see some comments have been made so will just merge everything and tidy up now

@chrismclarke
Copy link
Member

ok merged, feel free to pull from master

@chrismclarke
Copy link
Member

Also just to note, the update changes mobx from 5.x to 4.x (both actively supported), so will require a yarn install

@chrismclarke
Copy link
Member

Yeah things are getting a little bit messy as quite a few people are working on things related to discussions, with a fair mix of new features and refactoring. Sure, make the PR to discussions-backend, I'll review and merge with my code and the main discussions branch, before making a complete pr for review on Tuesday.

@BenGamma
Copy link
Contributor Author

BenGamma commented Mar 4, 2019

No worries, it's already helping a lot :)

  1. Would prefer if you start working with the src/pages/common/FilterBar which uses the src/components/Selector instead of material-ui
  2. Are you talking about the list sorting or the filter sorting ? Because I need to clarify list sorting with design team, meeting planed for tomorow morning, I'll keep you updated with the needed view in this thread.
  3. About algolia yes I would be curious to have your feedback after some tests. Before going into advanced usage such as request caching, automated content indexing when a post is saved and the ability to search for it would be a nice first step.

@BenGamma
Copy link
Contributor Author

BenGamma commented Mar 5, 2019

Ok, still seems a bit abstract to me but I'm sure it would be clarify with some code to look at.

To precise about the list sorting, there will be 3 type of sorting :

  • Latest
  • Most comments
  • Most useful

@BenGamma
Copy link
Contributor Author

Closing for now, will reopen when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants
@BenGamma @chrismclarke and others