-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion post list #215
Comments
Again really like the mockups, I don't think we've implemented any sortable table structure yet so it might be a good place to start investigation (I think there probably is already material table or similar, and plenty of third party packages depending on how much we want them to be able to do... I would suggest simpler is better). |
I put this lib on the side a few weeks ago https://github.com/bvaughn/react-virtualized It may be a bit overkill for what we want to do. Needs investigation. |
I think we're planning to try and nail down the database structure this week and will update the mocks. I had assumed we'd be mostly creating our own implementation but happy to explore solutions that already exist. The link you sent looks really promising, @BenGamma you might want to take a look. I reviewed the licence and fine for our purposes (non-commercial, non-competitive) |
Yep looks promising, you can start an integration of this lib with our current |
I don't think there would be pictures associated with each discussion thread so that might not be worth too much effort, although I could imagine a toggle between grid and list being useful if it could also be reused on other components like the how tos perhaps. |
Two of the next big pieces of work are implementing the tagging/filter system as well as search, I think that's where we could really implement some nice ways to help users find and engage with content easier |
@tx4x yes that's it ! we are working on the data structure right now, so consider that it will change in a close futur. |
I really like it, seems like nice and flexible way to implement an advanced filter system. The other mechanism for filtering content will be through a generic 'search' box which will hook up to a search engine and provide deeper content searches and ranking algorithms. If you'd be interested in that feature also there's more info in #328 |
discussions backend updated (pull #332). @BenGamma , shouldn't require proper review (testing and working as intended, also fixed the simple filter system), but will require |
plan to bind the create/edit workflow to the database tomorrow which should make it easier to create more substantial testing data (e.g. with correct tags, projects etc.) for use with filter system |
the discussion backend is most advanced and refactors quite a bit of the discussions more generally, there's a pr open for review but see some comments have been made so will just merge everything and tidy up now |
ok merged, feel free to pull from master |
Also just to note, the update changes mobx from 5.x to 4.x (both actively supported), so will require a yarn install |
Yeah things are getting a little bit messy as quite a few people are working on things related to discussions, with a fair mix of new features and refactoring. Sure, make the PR to discussions-backend, I'll review and merge with my code and the main discussions branch, before making a complete pr for review on Tuesday. |
No worries, it's already helping a lot :)
|
Ok, still seems a bit abstract to me but I'm sure it would be clarify with some code to look at. To precise about the list sorting, there will be 3 type of sorting :
|
Closing for now, will reopen when needed. |
We want to list all the posts available in the discussion section, e.g. mockup :
Use the mocks data available in the
mocks/mock.posts.tsx
folder to get all the post.child of #213
The text was updated successfully, but these errors were encountered: