Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRISP SRV17(BA) - compliance check #1770

Open
vishal-ondc opened this issue Nov 6, 2024 · 0 comments
Open

CRISP SRV17(BA) - compliance check #1770

vishal-ondc opened this issue Nov 6, 2024 · 0 comments

Comments

@vishal-ondc
Copy link
Collaborator

Flow 1:

OnSearch:
Message>catalog>providers - Same provider sending two times
Message>catalog>providers>descriptor>additional_desc- Its optional, if doesn’t have data, no need to send it
Message>catalog>providers>descriptor>code -Its optional, if doesn’t have data, no need to send it
Message>catalog>providers>descriptor>short_desc -Its mandatory, so send valid data
Message>catalog>providers>descriptor>long_desc -Its mandatory, so send valid data
Message>catalog>providers>rating - If no rating available then no need to send as its only allowed value is 1.0-5.0
Message>catalog>providers>locations>address - "CRISP ,,,Bhopal,Madhya Pradesh", Just for improvement, address should be valid and should not have unnecessary comma
Message>catalog>providers>items>descriptor>long_desc - Its mandatory, so send valid data
Message>catalog>providers>items>addon no need to if doesn’t contain any data
Message>catalog>providers>items>descriptor>media - Its optional, if doesn’t have data, no need to send it
Message>catalog>providers>items>cancellation_terms - Hope you have the cancellation terms on status basis and have implemented accordingly
Message>catalog>providers>items>tags>EQUIPMENT_ATTRIBUTES>RUNNING_HOURS - Its optional, if doesn’t have data, no need to send it
Message>catalog>providers>items>tags>EQUIPMENT_ATTRIBUTES>MISCELLANEOUS_INFO - Its optional, if doesn’t have data, no need to send it
Message>catalog>providers>items>tags>CHECKLIST_DOCUMENTS - Its attribute have NA values, its not allowed
Message>catalog>providers>items>time - its either be range based on frequency based time so if you defined the range then range and days are mandatory otherwise schedule frequency and time array
Message>catalog>providers>items>time>days - It should have valid data like “1,2,3,4,5,6,7”
Message>catalog>providers>items>time>frequency - its can’t be empty in case you have selected multiple time in times array
Message>catalog>providers>items>time>times - It should have valid array of date string

Flow 2:

Select
Message>order>items - Please select more then 1 item
###On_Select
Message>order>fullfillments>stops>end>location>area-code is not expected there
Message>order>provider>location is required
Message>order>quote>breakup>quantity>selected count is required instead of measure
Init
Message>order>fulfillments>id - its required
Message>order>fulfillments>type - It should be valid, End is not allowed
on_init
Message>order>fulfillments>stops>contact>email is required
Message>order>fulfillments>stops>ends>customer is not required
Mesage>order>items>tags>Checklist document all property is required
Message>payment>tags is required
Message>payment>id is required
Message>payment>params is required
confirm
Message>order>items>tags>CHECKLIST_DOCUMENTS - Its all attribute should be present)
Message>order>payments>params>virtual_payment_address - missing value
Message>order>payments>tags - Missing
Message>order>quote>breakup>quantity>selected count is required instead of measure
on_confirm
Message>order>provider>locations - missing
Message>order>items>tags>CHECKLIST_DOCUMENTS - Its all attribute should be there
Message>order>fulfillments>rateable is missing
Message>order>fulfillments>state is missing
Message>order>fulfillments>stops>start>location>id is missing
Message>order>fulfillments>stops>end>contact>email is missing
Message>order>fulfillments>stops>instructions is missing
Message>order>payments>params>virtual_payment_address - missing value
Message>order>quote>breakup>quantity>selected count is required instead of measure
Message>order>payments>tags - Missing
on_status (AT_LOCATION, completed, In transit)
Message>order>provider>locations - missing
Message>order>billing>email - missing
Message>order>fulfillments>rateable is missing
Message>order>fulfillments>state is missing
Message>order>fulfillments>stops>end>contact>email is missing
Message>order>fulfillments>stops>instructions is missing
Message>order>documents is missing
Message>order>payments>params>virtual_payment_address - missing value
Message>order>payments>tags - Missing

FLow 3:

All the issues same as flow 2
Onselect:
	Message>order>provider>locations - missing
	Message>order>items>time>schedule - missing
	Message>order>fulfilments>stops>end>location>areacode is not required
	Message>order>quote is not required

Flow 4:

All issues same as flow 2

Init:
Message>order>fulfillments>id - its required
Message>order>fulfillments>type - It should be valid, End is not allowed
on_init
Message>order>fulfillments>stops>contact>email is required
Message>order>fulfillments>stops>ends>customer is not required
Mesage>order>items>tags>Checklist document all property is required
Message>payment>tags is required
Message>payment>id is required
Message>payment>params is required

Flow 5:

All issues same as flow 2

Oncancel:
Message>order>fulfillments>stops>start>contact>email shoul be valid
Message>order>fulfillments>stops>end instructions is required
Message>order>fulfillments>stops>end>contact>email is required
Message>order>items>tags is not required
Message>order>payment>params>virtual payment address is missing
Message>order>payment>params>tags is missing
Message>order>quote>breakup>quantity>selected count is required instead of measure

Flow 6:

All issues same as flow 2
Oncancel:
Message>order>fulfillments>stops>start>contact>email shoul be valid
Message>order>fulfillments>stops>end instructions is required
Message>order>fulfillments>stops>end>contact>email is required
Message>order>items>tags is not required
Message>order>payment>params>virtual payment address is missing
Message>order>payment>params>tags is missing
Message>order>quote>breakup>quantity>selected count is required instead of measure

@vishal-ondc vishal-ondc changed the title CRISP SRV17(BA) - compliance check #1757 CRISP SRV17(BA) - compliance check Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant