Ninjacart B2B BAP - compliance check

[abhinavv245]

Flow 1

/search

• fulfillment/stops/0/location/gps Incorrect gps value (minimum of six decimal places are required)
• Reverse Geocoding for end failed. Area Code 680354 not matching with 1.3826059101531494, 103.743617819222 Lat-Long pair.
• real values should be provided for tags (buyer_id_no)

/select

• provider details provided in /on_search are valid for 2 days (provider/ttl = P2D), why is select call made after 20 days?
• provider/ttl and items/tags (BUYER_TERMS) are not required for Non RFQ Flow

/on_select

• order/payments/0 must have required property 'collected_by' (BAP should perform schema validation)

/init

• provider must NOT have additional properties (ttl)
• dummy text should be avoided in /billing (tax_id)

/on_init

• payments/0 must have required property 'type', 'collected_by', @ondc/org/settlement_basis', '@ondc/org/settlement_window', '@ondc/org/withholding_amount' (BAP should validate)

/confirm

• order/created_at and updated_at cannot be future dated w.r.t contex.timestamp
• provider/ttl not required

/on_confirm

• settlement details cannot be changed by BPP (BAP should validate)

/status

• /status API should be implemented

[abhinavv245]

Non RFQ Flow

Flow 1

• avoid using dummy values

/search

• not a valid gst number in buyer_id_code in order/tags

/select

• provider/ttl is not required for Non RFQ Flow

/init

• billing/tax number should be valid

/confirm

• order/id should be unique (not equal to transaction_id)
• /confirm/0/message/order/state must be equal to one of the allowed values (Created)
• order/created_at and updated_at cannot be future dated w.r.t context/timestamp
• order/billing/email mismatch from /init
• bpp_terms and bap_terms are missing in order/tags
• payments/params/transaction_id attribute is not required in case payment/status = NOT-PAID
• settlement details should be provided by buyer app in case payment is collected by BPP

Flow 3 and onwards

• similar issues

/confirm

• settlement details provided by seller app are missing

Flow 5

/select

• no change in location in both select calls

/on_select(reject)

• on what basis is location not serviceable error thrown?

RFQ Flow

• similar issues as above

/init

• context/ttl must be equal to constant (PT30S)

/confirm

• order/state must be equal to one of the allowed values (Created)
• context/ttl must be equal to constant (PT30S)
• order/updated_at does not match created_at timestamp - "2024-02-07T17:21:41.929Z\
• billing/city/name must be equal to constant (Bangalore)

Note: Kindly fix all the identified issues above and from the log verification utility before submitting the logs.

[tanyamadaan]

Non-RFQ Flow:

The payment collected by is BPP in /on_search and /on_select. How it got changed to BAP in /init.

cancellation flows missing.