Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurikatech (BA: RET 12) - compliance checks #2871

Open
sandeepshahi opened this issue Dec 4, 2024 · 3 comments
Open

Aurikatech (BA: RET 12) - compliance checks #2871

sandeepshahi opened this issue Dec 4, 2024 · 3 comments

Comments

@sandeepshahi
Copy link
Member

Please submit the logs after testing with a verified counterparty SNP in preprod.

@akhtarmdsaad

@pareenjain
Copy link

pareenjain commented Dec 4, 2024

@sandeepshahi do we need to submit all logs for all Flows with another SNP?
cc: @vanshraghav

@pareenjain
Copy link

@sandeepshahi - just wanted to ensure that our logs are being reviewed since the PR got merged?
cc: @vanshraghav @akhtarmdsaad

@Jagannath-wits
Copy link

Flow 1

- Buyer should send NACK for the following.

on_search

  • Invalid item value for fabric (i.e., 'animal')
  • Mandatory tag field colour_name missing for Fashion item. colour_name is mandatory and required by buyer apps to render and populate correctly.
  • Why is items.descriptor.code missing from every item?

Flow 2

on_select

  • fulfillments/@ondc/org/TAT (O2D) in /on_select can't be less than @ondc/org/time_to_ship (O2S) in /on_search.

on_init

  • provider_tax_number should be provided.

confirm

  • Payment settlement_details mismatch in /on_init & /confirm.
  • How did collected_by change in confirm? This should be Nacked.

on_confirm

  • cancellation_terms in /message/order should not be provided as those are not enabled yet.
  • np_type is missing in message/order/tags/bpp_terms.

on_status_pending

  • Invoice URL must be present as part of documents objects (only in Order-picked-up state and thereafter).
  • Created At timestamp for /on_status_pending should be equal to the context timestamp at confirm.
  • Timestamp for /on_confirm API cannot be greater than or equal to /on_status_pending API.
  • (on status packed and picked missing).

on_status_out_for_delivery

  • Tags are missing in delivery fulfillment.
  • Mismatch when comparing Delivery fulfillment start timestamp with the on_status_picked.
  • Mismatch when comparing 'Delivery' fulfillment object with on_status_pending on key @ondc/org/TAT.
  • Mismatch when comparing 'Delivery' fulfillment object with on_status_pending on keys start/time and end/time.

on_status_delivered

  • Message ID is the same as previous calls.
  • Tags are mandatory.
  • Rest same as previous calls.

Flow 4

on_cancel

  • precancel_state.updated_at of /on_cancel should be equal to the on_confirm order updated_at.

Flow 5

on_cancel

  • How is cancellation initiated by Buyer?

Flow 7

catalog_rejection

  • Please remove Invalid key errors._id.

@pareenjain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants