Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oxidised methane to carbon pools #93

Open
FrankErrickson opened this issue Nov 5, 2020 · 2 comments
Open

Adding oxidised methane to carbon pools #93

FrankErrickson opened this issue Nov 5, 2020 · 2 comments

Comments

@FrankErrickson
Copy link

@kar5469 and I are working on a project that couples in a new methane cycle model into FAIR (but coded up in Julia) and had a quick question on how you handle oxidised methane. It looks like the oxidised_CH4 term is being added to all four carbon pools (i.e. see Line 636 in forward.py).

We weren't sure if we were just misinterpreting something, or if this is actually adding 4x the oxidised CH4 amount? We'd appreciate any thoughts/insights you have.

@chrisroadmap
Copy link
Collaborator

Yep this looks like an error - I'll make a PR

@chrisroadmap
Copy link
Collaborator

Interestingly this doesn't fail any of the pre-calculated tests: so while it was implemented clunkily it wasn't affecting the model results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants