Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent methane lifetime reaching zero #141

Open
chrisroadmap opened this issue Oct 31, 2023 · 0 comments
Open

Prevent methane lifetime reaching zero #141

chrisroadmap opened this issue Oct 31, 2023 · 0 comments
Milestone

Comments

@chrisroadmap
Copy link
Collaborator

in some very warm runs in e.g. ssp585 beyond 2100, using ch4_method="Thornhill", the methane lifetime adjustment due to temperature can get large. This causes this line:

np.log(1 + temperature * ch4_lifetime_temperature_sensitivity)

to become negative in the log term if ch4_lifetime_temperature_sensitivity is negative and temperature is large. This tends to happen in ensemble members above 15 K. The likelihood of FaIR being a reliable model in such extreme warming is small and these sorts of projections should be used with caution anyway, but there should be a sensible minimum value for the methane lifetime that can be set in the call to FaIR that would override the calculation if this log term becomes too small or NaN.

@chrisroadmap chrisroadmap added this to the v2.2 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant