Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt: fix consumed bytes computation for truncated msg #7231

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
No ticket yet, https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44225

Describe changes:

  • mqtt : fixes consumed bytes computation in truncated case

cc @satta following #7152

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #7231 (239e282) into master (013fb2d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7231      +/-   ##
==========================================
- Coverage   77.99%   77.98%   -0.01%     
==========================================
  Files         628      628              
  Lines      184464   184464              
==========================================
- Hits       143864   143846      -18     
- Misses      40600    40618      +18     
Flag Coverage Δ
fuzzcorpus 60.13% <ø> (ø)
suricata-verify 54.62% <ø> (-0.03%) ⬇️
unittests 62.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@satta
Copy link
Contributor

satta commented Apr 11, 2022

Ah, you already fixed it! Thanks!

@satta
Copy link
Contributor

satta commented Apr 11, 2022

However, I think this also needs to be done analogously in parse_request().

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 6881

@catenacyber
Copy link
Contributor Author

Replaced by #7236

jasonish pushed a commit to jasonish/suricata that referenced this pull request Nov 14, 2024
jasonish pushed a commit to jasonish/suricata that referenced this pull request Nov 14, 2024
jasonish pushed a commit to jasonish/suricata that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs ticket Needs (link to) redmine ticket
Development

Successfully merging this pull request may close these issues.

4 participants