Add keyword to match on 'raw' TLS certificates #3542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add keyword to do "raw" matching on the TLS certificate buffer.
Example:
alert tls any any -> any any (msg:"tls_cert test"; tls_cert; \
content:"|01||02||03||04|"; sid:1;)
Rename buffer type for the old TLS keywords to avoid a name conflict with the 'tls_cert' keyword.
|
Replaced by #3545 |
This was referenced Mar 19, 2020
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 2, 2022
Set correct direction for PORT mode, where the server connects to the client. The direction is not also strictly enforced. No data in the wrong direction will be accepted to setup the file or to be added to the file after setup. This also fixes files getting closed twice. Adds some general cleanups. Bug: OISF#3542.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 3, 2022
Set correct direction for PORT mode, where the server connects to the client. The direction is not also strictly enforced. No data in the wrong direction will be accepted to setup the file or to be added to the file after setup. This also fixes files getting closed twice. Adds some general cleanups. Bug: OISF#3542. (cherry picked from commit 07bf921)
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 3, 2022
Set correct direction for PORT mode, where the server connects to the client. The direction is not also strictly enforced. No data in the wrong direction will be accepted to setup the file or to be added to the file after setup. This also fixes files getting closed twice. Adds some general cleanups. Bug: OISF#3542. (cherry picked from commit 07bf921)
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
May 4, 2022
Set correct direction for PORT mode, where the server connects to the client. The direction is not also strictly enforced. No data in the wrong direction will be accepted to setup the file or to be added to the file after setup. This also fixes files getting closed twice. Adds some general cleanups. Bug: OISF#3542. (cherry picked from commit 07bf921)
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
May 17, 2022
Set correct direction for PORT mode, where the server connects to the client. The direction is not also strictly enforced. No data in the wrong direction will be accepted to setup the file or to be added to the file after setup. This also fixes files getting closed twice. Adds some general cleanups. Bug: OISF#3542.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new keyword
tls_certto match on the 'raw' TLS certificate. This keyword matches on the first certificate in the certificate chain.Example:
alert tls any any -> any any (msg:"test tls_cert"; tls_cert; content:"|01||02||03||04|"; sid:1;)https://redmine.openinfosecfoundation.org/issues/2670
Prscript: