Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/ldap v0.3: small improvements to the LDAP parser #12152

Closed
wants to merge 2 commits into from

Conversation

chifflier
Copy link
Contributor

Previous PR: #12119

Description:
This pull request does minor changes to the LDAP app-layer:

  • add port 3268 to the default monitored ports. This port is used by ActiveDirectory for global operations (not local to the current domain)
  • Add support for the STARTTLS extended operation, so now the TLS handshake (and the Certificate) can be inspected and logged. It also takes care to check if STARTTLS succeeds, to avoid errors.

Redmine Ticket: https://redmine.openinfosecfoundation.org/issues/7394

SV_BRANCH=OISF/suricata-verify#2128

@victorjulien victorjulien added this to the 8.0 milestone Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.66%. Comparing base (13841c0) to head (f318ec6).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (13841c0) and HEAD (f318ec6). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (13841c0) HEAD (f318ec6)
suricata-verify 1 0
fuzzcorpus 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12152       +/-   ##
===========================================
- Coverage   49.77%   33.66%   -16.12%     
===========================================
  Files         909      909               
  Lines      257884   257685      -199     
===========================================
- Hits       128367    86752    -41615     
- Misses     129517   170933    +41416     
Flag Coverage Δ
fuzzcorpus ?
livemode 19.44% <10.52%> (+<0.01%) ⬆️
pcap 44.40% <100.00%> (-0.01%) ⬇️
suricata-verify ?
unittests 8.98% <10.52%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

Merged in #12156, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants