[draft] flow callbacks, thread callbacks, user thread storage; eve callbacks; ndpi stub plugin - v3 #11944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For library users and plugins that need to hook into the thread life cycle, perhaps to initialize some thread storage.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11944 +/- ##
==========================================
- Coverage 82.74% 82.72% -0.02%
==========================================
Files 912 915 +3
Lines 249102 249290 +188
==========================================
+ Hits 206117 206235 +118
- Misses 42985 43055 +70
Flags with carried forward coverage won't be shown. Click here to find out more. |
Provide a way for library/plugin users to register a callback that will be called prior to an EVE record being closed. The callback will be passed ThreadVars, Packet, and Flow pointers if available, as well as private user data.
This plugin stub shows how a plugin like nDPI might be use the flow init and flow update callbacks to do its work. Also shows usage of FlowStorage to avoid modifying the Flow struct directly.
jasonish
force-pushed
the
ndpi-dummy-plugin/v3
branch
from
3a92fc2
to
6607ef3
Compare
|
Information: QA ran without warnings. Pipeline 23092 |
|
See #11970. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11942, but with EVE callback.
I think this gives what is required to make nDPI a plugin, still draft as it has a stub plugin for example purposes.