Ssh frames 5734 v3 #11415
Closed
Ssh frames 5734 v3 #11415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5734 Adds frames for SSH records, that come after banner, and before the data is encrypted. These records may contain cipher lists for instance.
for SSH packets that mark the end of plaintext
use debug_validate_bug_on instead
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11415 +/- ##
==========================================
+ Coverage 82.43% 82.45% +0.02%
==========================================
Files 938 938
Lines 248044 248098 +54
==========================================
+ Hits 204465 204579 +114
+ Misses 43579 43519 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 21396 |
inashivb
reviewed
Jul 8, 2024
| // app-layer-frame-documentation tag start: FrameType enum | ||
| #[derive(AppLayerFrameType)] | ||
| pub enum SshFrameType { | ||
| RecordHdr, |
There was a problem hiding this comment.
Q: No other frames seem to have this naming scheme with Record prefix. Why did you choose it?
There was a problem hiding this comment.
Because SSH has different stages : banner, records, and encrypted
So, the frames are about records only
Closed
|
Continued in #11451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5734
Describe changes:
panicin packet pathSV_BRANCH=OISF/suricata-verify#1932
#11372 with better commit message and some doc added, and adds a cleanup commit