fixup! detect/dataset: delay set operation after signature full match

OISF · Oct 29, 2024 · a89a2ed · a89a2ed
1 parent c8906bc
commit a89a2ed
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/detect-engine-content-inspection.c b/src/detect-engine-content-inspection.c
@@ -772,7 +772,7 @@ bool DetectEngineContentInspectionBuffer(DetectEngineCtx *de_ctx, DetectEngineTh
         return false;
 }
 
-uint8_t DetectEngineContentInspectionBufferMulti(DetectEngineCtx *de_ctx,
+int DetectEngineContentInspectionBufferMulti(DetectEngineCtx *de_ctx,
         DetectEngineThreadCtx *det_ctx, const Signature *s, const SigMatchData *smd, Flow *f,
         const InspectionBuffer *b, uint32_t local_id)
 {

diff --git a/src/detect-engine-content-inspection.h b/src/detect-engine-content-inspection.h
@@ -68,7 +68,7 @@ bool DetectEngineContentInspectionBuffer(DetectEngineCtx *de_ctx, DetectEngineTh
         const Signature *s, const SigMatchData *smd, Packet *p, Flow *f, const InspectionBuffer *b,
         const enum DetectContentInspectionType inspection_mode);
 
-uint8_t DetectEngineContentInspectionBufferMulti(DetectEngineCtx *de_ctx,
+int DetectEngineContentInspectionBufferMulti(DetectEngineCtx *de_ctx,
         DetectEngineThreadCtx *det_ctx, const Signature *s, const SigMatchData *smd, Flow *f,
         const InspectionBuffer *b, uint32_t local_id);
 

diff --git a/src/detect-engine.c b/src/detect-engine.c
@@ -2219,7 +2219,7 @@ uint8_t DetectEngineInspectMultiBufferGeneric(DetectEngineCtx *de_ctx,
 
         // The GetData functions set buffer->flags to DETECT_CI_FLAGS_SINGLE
         // This is not meant for streaming buffers
-        uint8_t match = DetectEngineContentInspectionBufferMulti(
+        int match = DetectEngineContentInspectionBufferMulti(
                 de_ctx, det_ctx, s, engine->smd, f, buffer, local_id);
         switch (match) {
             case DETECT_ENGINE_INSPECT_SIG_MATCH: