Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHIF About Info for OS is incorrect while using a Mac #3802

Closed
tzuccher opened this issue Nov 23, 2023 · 2 comments
Closed

OHIF About Info for OS is incorrect while using a Mac #3802

tzuccher opened this issue Nov 23, 2023 · 2 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@tzuccher
Copy link

Describe the Bug

OHIF About Info for OS is incorrect while using a Mac. The OS is reported as OS X 10.15.7
This Mac OS is incorrect as my MacBook Pro version is Sonoma 14.1.1

image

image

Steps to Reproduce

This was found in both of the following environments:
https://viewer.ohif.org/ - version 3.7.0
https://viewer-dev.ohif.org/ - version 3.8.0-beta.21

  1. Select the wheel icon or the drop-down icon from the upper right corner of the OHIF screen(s)
  2. Select the About option
  3. Verify the Browser & OS info = the OS info on my Mac displays: OS X 10.15.7 however, my Mac version is Sonoma 14.1.1

The current behavior

The About info is reporting the incorrect OS version

The expected behavior

The About info should report the correct OS (& browser info)...or, no info at all

OS

MacBook Pro - Sonoma 14.1.1

Node version

unknown

Browser

Chrome v119

@tzuccher tzuccher added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 23, 2023
@sedghi sedghi added Bug Verified Bug reported, reproducible, and verified. Awaiting Reproduction Can we reproduce the reported bug? and removed Awaiting Reproduction Can we reproduce the reported bug? labels Nov 28, 2023
@sedghi sedghi self-assigned this Nov 28, 2023
@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Nov 28, 2023
@sedghi
Copy link
Member

sedghi commented Feb 21, 2024

Seems like an intentional security approach by apple, they have stopped properly mentioning the os version

https://discussions.apple.com/thread/253178691

https://www.otsukare.info/2021/02/15/capping-macos-user-agent

Other detectors also have issues, so i'm just removing the version

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Bug Verified Bug reported, reproducible, and verified. labels Feb 21, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

2 participants