Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] New extension template outdated dependency version @ohif/i18n #3656

Closed
jennydaman opened this issue Sep 14, 2023 · 1 comment · Fixed by #3689
Closed

[Bug] New extension template outdated dependency version @ohif/i18n #3656

jennydaman opened this issue Sep 14, 2023 · 1 comment · Fixed by #3689
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@jennydaman
Copy link

Describe the Bug

Viewers/platform/cli/templates/extension/dependencies.json

Line 21 in bd7f959

"@ohif/i18n": "^1.0.0",

Version should be at least 3.6.0

Steps to Reproduce

  1. yarn run cli create-extension
  2. cd /path/to/created_extension
  3. npm i

The current behavior

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @ohif/i18n@undefined
npm ERR! node_modules/@ohif/i18n
npm ERR!   peer @ohif/i18n@"^1.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @ohif/i18n@"3.6.0" from @ohif/[email protected]
npm ERR! node_modules/@ohif/extension-default
npm ERR!   peer @ohif/extension-default@"^3.0.0" from the root project

The expected behavior

npm i should work out-of-the-box

OS

Arch Linux

Node version

v20.6.1

Browser

N/A
@jennydaman jennydaman added the Awaiting Reproduction Can we reproduce the reported bug? label Sep 14, 2023
@sedghi sedghi linked a pull request Oct 4, 2023 that will close this issue
fix(cli): Add npm packaged mode not working #3689
Merged
6 tasks
@sedghi
Copy link
Member

sedghi commented Oct 4, 2023

This seems to be done #3689

@sedghi sedghi closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): Add npm packaged mode not working jbocce/Viewers
2 participants
@sedghi @jennydaman