-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] TotalSegmentator dataset taking longer to load compared to v2 #3523
Comments
Were you supposed to share a screenshot or a dataset? |
Remember the drive I shared with a bunch of datasets e.g. the RGB one? there you can find the totalsegmentator dataset. |
This file doesn't have a SEG I'm using another study which you can find here, but I'm not able to load it in v2 either |
@sedghi I just uploaded another zip with the seg file to that drive. |
@fedorov do you have another TotalSegmentator studies to test, to try to understand if this is an isolated problem? |
Using the link: https://viewer.imaging.datacommons.cancer.gov/viewer/61.7.186150680759207515465616855509993541745 Using exactly the same images for both viewers, the loadign appears to be very similar |
@fedorov, do you want to investigate why v2 didnt load the full segmentation? |
The study in IDC contains only the segmentation that was loaded. It does not have the same segmentation with 98 segments shared separately. |
The file shared with Ali Reza has it. Anyway, problem seems to be solved. |
To confirm, tests O16 and O19 in the IDC test inventory (access restricted to IDC project participants) should be used to test this functionality. |
I confirmed performance is very good now, nice work @rodrigobasilio2022! 👍 |
Describe the Bug
Based on recent tests with v2 and v3 we identified that the loading of the segmentations are faster in v2.
This issue should further investigate and address the problem.
Steps to Reproduce
The current behavior
Loads slower in v3
The expected behavior
Loads better or equal to v2
OS
macOS 13.4 (22F66)
Node version
16
Browser
Version 114.0.5735.198 (Official Build) (x86_64)
The text was updated successfully, but these errors were encountered: