Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing/loading “time to first image” #3480

Closed
igoroctaviano opened this issue Jun 20, 2023 · 8 comments
Closed

Improve parsing/loading “time to first image” #3480

igoroctaviano opened this issue Jun 20, 2023 · 8 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) IDC:priority Items that the Imaging Data Commons wants to help sponsor

Comments

@igoroctaviano
Copy link
Contributor

igoroctaviano commented Jun 20, 2023

Request

Investigate and implement possible improvements to the performance when loading the sample study below.

Context

The time to first image (the time that it takes to render the first image in the viewport after a full reload) was higher in the new v3 version compared to OHIF v2 (legacy).

V2: https://testing-viewer.canceridc.dev/viewer/1.3.12.2.1107.5.1.4.60175.30000008042114404745300000007 - 13 sec

V3: https://ohif-v3.web.app/viewer?StudyInstanceUIDs=1.3.12.2.1107.5.1.4.60175.30000008042114404745300000016 - 35 sec

@fedorov
Copy link
Member

fedorov commented Jun 20, 2023

@igoroctaviano the issue discussed in the document where you transferred this from is not about SEG - it is in general an observation that for that study it takes much longer for the first image to show up in the viewer than in v2. There are no segmentations in that study.

@fedorov fedorov changed the title Improve SEG parsing/loading “time to first image” Improve parsing/loading “time to first image” Jun 20, 2023
@igoroctaviano
Copy link
Contributor Author

@fedorov there's also the issue with the totalsegmentator dataset. Do we need an independent issue for that?

@fedorov fedorov added the IDC:priority Items that the Imaging Data Commons wants to help sponsor label Jun 29, 2023
@fedorov
Copy link
Member

fedorov commented Jun 29, 2023

Yes, we need a separate issue comparing the performance of loading large SEG between v2 and v3.

@rodrigobasilio2022
Copy link
Collaborator

PR opened

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Oct 13, 2023
@igoroctaviano
Copy link
Contributor Author

@rodrigobasilio2022 can you please follow up with @sedghi to get the PR merged?

@sedghi
Copy link
Member

sedghi commented Apr 3, 2024

also this one is finished?

@igoroctaviano
Copy link
Contributor Author

@sedghi yes, it's finished.

@sedghi sedghi added the fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) label Apr 3, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
Status: Done
Development

No branches or pull requests

5 participants