Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurements and Study Date are not translated #3334

Closed
nicoesiea opened this issue Apr 21, 2023 · 5 comments
Closed

Measurements and Study Date are not translated #3334

nicoesiea opened this issue Apr 21, 2023 · 5 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@nicoesiea
Copy link

Describe the Bug

On Measurements right panel I can see the words "Measurements" and "StudyDate" which are not translated into the current language.
image

Steps to Reproduce:

  1. Open the viewer
  2. Change the default language: top right corner, click on Options, go on panel General, and choose Spanish or French
  3. Submit the selection by clicking on the SAVE button
  4. Measurements menu is still the same when it should be "Medidas" or "Mesures" in Spanish or in French
  5. Inside the Measurements menu, the word StudyDate looks to be wrong (probably a bad translation keyword)

The current behavior

The translation is not working as expected

The expected behavior

The displayed word must be translated according to the selected language

NOTE: sorry if I was wrong to open this issue - that the only way I know how to report this kind of bug (if it is a bug!)

@sedghi
Copy link
Member

sedghi commented Oct 13, 2023

@jbocce ditto

@jbocce
Copy link
Collaborator

jbocce commented Oct 13, 2023

Measurements is still displayed with NO translation, however StudyDate no longer appears in the measurements' side panel

@jbocce jbocce added Bug Verified Bug reported, reproducible, and verified. and removed Awaiting Reproduction Can we reproduce the reported bug? labels Oct 13, 2023
@james-hanks
Copy link

@sedghi to provide documentation to allow community fix

@sedghi
Copy link
Member

sedghi commented Nov 15, 2023

@nicoesiea Hey, do you mind checking this documentation https://docs.ohif.org/platform/internationalization
and maybe shoot us a PR?

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Bug Verified Bug reported, reproducible, and verified. labels Jan 9, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

4 participants