Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample_settings.xml authentication query should better match the Basic Security Configuration wiki page #2392

Open
amarsan opened this issue Sep 12, 2024 · 1 comment · May be fixed by #2394

Comments

@amarsan
Copy link

amarsan commented Sep 12, 2024

This a companion issue to OHDSI/webapi-wiki#10

Expected behavior

The security.db.datasource.schema and authentication query should match the schema, table, and column names that are recommended in the Basic Security Configuration wiki page.

<security.db.datasource.schema>atlas-security</security.db.datasource.schema>
<security.db.datasource.authenticationQuery>select password,firstName,middleName,lastName from ${security.db.datasource.schema}.users where username = ?</security.db.datasource.authenticationQuery>

The wiki page recommends that we do not put the security table in the webapi schema, so the security.db.datasource.schema node should be updated accordingly.

The wiki page recommends naming the table demo_security, but I noted in the referenced webapi-wiki issue that the name users makes more sense, so I think we should continue to use that here.

The wiki page recommends having a column called username, rather than email, so that should be fixed.

Actual behavior

<security.db.datasource.schema>${datasource.ohdsi.schema}</security.db.datasource.schema>
<security.db.datasource.authenticationQuery>select password from ${security.db.datasource.schema}.users where lower(email) = lower(?)</security.db.datasource.authenticationQuery>

Steps to reproduce behavior

N/A

@chrisknoll
Copy link
Collaborator

Agreed, we shouldn't put an example settings that conflicts with the documentation recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants