Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The number and percent of records with a value in the QUANTITY field of the DRUG_EXPOSURE table greater than 1095. (threshold 1%) - should be checked only for solid forms #512

Open
dimshitc opened this issue Nov 30, 2023 · 3 comments
Assignees
Labels
check bug/enhancement DQ check SQL logic has a bug or needs refinement

Comments

@dimshitc
Copy link
Collaborator

Please, see the rule:
If liquid, quantity stands for the total amount dispensed or ordered of ingredient in the units given by the drug_strength table. If the unit from the source data does not align with the unit in the DRUG_STRENGTH table the quantity should be converted to the correct unit given in DRUG_STRENGTH. For clinical drugs with fixed dose forms (tablets etc.) the quantity is the number of units/tablets/capsules prescribed or dispensed (can be partial, but then only 1/2 or 1/3, not 0.01). Clinical drugs with divisible dose forms (injections) the quantity is the amount of ingredient the patient got. For example, if the injection is 2mg/mL but the patient got 80mL then quantity is reported as 160. Quantified clinical drugs with divisible dose forms (prefilled syringes), the quantity is the amount of ingredient similar to clinical drugs.

This way, the quantity can be big for liquids, like 2000 mg or so.
@katy-sadowski by the way, do you know by any chance why the number of 1095 was chosen?

@katy-sadowski
Copy link
Collaborator

I have no clue why 1095 was chosen - @clairblacketer might? But either way, I wonder if we should be checking this at all given how much the actual plausible range for this will vary among drug exposures. I think I'd vote to toggle off the check for this field altogether... And someday if we want to do it right it'd really be a concept-level check with ranges per drug. What do you guys think?

@katy-sadowski katy-sadowski added the check bug/enhancement DQ check SQL logic has a bug or needs refinement label Dec 2, 2023
@burrowse
Copy link

burrowse commented Dec 6, 2024

@katy-sadowski +1 for a concept level check with ranges per drug! Sounds similar to #102 that @vojtechhuser mentioned a while back too!

@katy-sadowski
Copy link
Collaborator

katy-sadowski commented Dec 7, 2024

Thanks for reactivating this @burrowse 😃 it looks like I never actually toggled off this check in the default threshold files - do you think I should? (In my experience failures of this check have always turned out to be legitimate quantities above 1095).

Any thoughts on how we might go about generating the concept-level ranges? I wonder if we could leverage the drug_strength table in some way so we don't actually need to implement this as a concept-level check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check bug/enhancement DQ check SQL logic has a bug or needs refinement
Projects
Status: No status
Development

No branches or pull requests

3 participants