Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplifying remove render targets in more C++11 style #2524

Merged
merged 4 commits into from
Jul 26, 2022
Merged

simplifying remove render targets in more C++11 style #2524

merged 4 commits into from
Jul 26, 2022

Conversation

Joilnen
Copy link
Contributor

@Joilnen Joilnen commented Jul 26, 2022

No description provided.

Joilnen
Joilnen commented Jul 26, 2022
View reviewed changes
Copy link
Contributor Author

@Joilnen Joilnen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping primary like the original code in a second commit

@Joilnen Joilnen requested a review from paroj July 26, 2022 15:43
Joilnen
Joilnen commented Jul 26, 2022
View reviewed changes
Copy link
Contributor Author

@Joilnen Joilnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@Joilnen
Update OgreRenderSystem.cpp
7512d81 
discarding not necessary variable
Joilnen
Joilnen commented Jul 26, 2022
View reviewed changes
Copy link
Contributor Author

@Joilnen Joilnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to review

@paroj paroj merged commit 1f61c5d into OGRECave:master Jul 26, 2022
@Joilnen Joilnen deleted the fix_03 branch July 27, 2022 11:17
paroj added a commit to paroj/ogre that referenced this pull request Jul 16, 2024
@paroj
Revert "Main: RenderSystem - simplifying remove render targets (OGREC…
8e3ae71 
…ave#2524)"

This reverts commit 1f61c5d.
paroj added a commit that referenced this pull request Jul 17, 2024
@paroj
Revert "Main: RenderSystem - simplifying remove render targets (#2524)"
56d3427 
This reverts commit 1f61c5d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paroj paroj paroj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joilnen @paroj