fix crash in the ControllerManager::updateAllControllers when mContro…

…llers is changed while iterating over it
OGRECave · Sep 7, 2024 · d9c40c0 · d9c40c0
1 parent d111e9d
commit d9c40c0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/OgreMain/src/OgreControllerManager.cpp b/OgreMain/src/OgreControllerManager.cpp
@@ -77,9 +77,10 @@ namespace Ogre {
         unsigned long thisFrameNumber = Root::getSingleton().getNextFrameNumber();
         if (thisFrameNumber != mLastFrameNumber)
         {
-            for (auto *ci : mControllers)
+            // intentionally do a loop using indices, because mControllers might change within the loop
+            for (size_t i = 0; i < mControllers.size(); ++i)
             {
-                ci->update();
+                mControllers[i]->update();
             }
             mLastFrameNumber = thisFrameNumber;
         }