Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin not working since latest update #58

Open
setianke opened this issue Apr 24, 2020 · 2 comments
Open

Plugin not working since latest update #58

setianke opened this issue Apr 24, 2020 · 2 comments

Comments

@setianke
Copy link

I tried with fresh and current OctoberCMS installs, App URL is correctly set. The Middleware is not replacing the tags anymore since the update today.

@setianke
Copy link
Author

Okay found the issue with the help of the logs

"[OFFLINE.ResponsiveImages] DOM manipulation failed: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2"

and adding an "@" in DomManipulator.php Line 125 like:

@$this->dom->loadHTML(mb_convert_encoding($tag, 'HTML-ENTITIES', 'UTF-8'));

fixed the issue for me as some HTML5 elements resulted in Warnings which are now suppressed

@tobias-kuendig
Copy link
Member

Are you sure this is about HTML5 elements? The DOM parser shouldn't care about HTML versions as it only parses the XML structure. Also, suppressing warnings isn't an ideal solution. Is it possible, that your HTML code was invalid? Do you have an example of a img tag that did not work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants