Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] website_snippet_country_dropdown: Migration to 16.0 #986

Merged
merged 21 commits into from
Jun 5, 2024
Merged

[16.0][MIG] website_snippet_country_dropdown: Migration to 16.0 #986

merged 21 commits into from
Jun 5, 2024

Conversation

kaynnan
Copy link

@kaynnan kaynnan commented Jun 27, 2023

@kaynnan kaynnan force-pushed the 16.0-mig-website_snippet_country_dropdown branch 7 times, most recently from 0c3fa1e to 1acf24a Compare June 27, 2023 20:35
@kaynnan kaynnan marked this pull request as ready for review June 27, 2023 20:41
marcelsavegnago
marcelsavegnago approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NICO-SOLUTIONS
NICO-SOLUTIONS reviewed Jul 8, 2023
View reviewed changes
Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. LG

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@kaynnan
Copy link
Author

kaynnan commented Nov 5, 2023

ping @OCA/website-maintainers

@pedrobaeza
Copy link
Member

Please rebase to check runboat.

/ocabot migration website_snippet_country_dropdown

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 6, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 6, 2023
Open
13 tasks
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023
@edlopen
Copy link
Member

edlopen commented Jan 31, 2024

Hello @kaynnan , I am interested in having this module migrated. Thanks in advance!

sergio-teruel and others added 12 commits February 1, 2024 00:37
@sergio-teruel @kaynnan
[NEW][8.0] website_snippet_country_dropdown: New base module for coun…
5ec3416 
…try dropdown flags.
@yajo @kaynnan
[IMP] website_snippet_country_dropdown: Several things:
c5f94b1 
* Add demo page.
* CSS to Sass. Include compiled version and CSS map.
* Fix typo.
* Refactor snippet code.

  - The `js_country_dropdown` class is added automatically by the template.
  - Add `extra_class` variable to highest div element. You can set it to `has-error` for example.
  - Add `default_value` variable to autopopulate the inputs.
  - `default_country` is smarter now.
* Translate to Spanish.
* Choose user's country by default.

  With this patch, when the currently logged-in user has a country in its profile, it will be chosen by default for the flag.
@yajo @kaynnan
[MIG] website_snippet_country_dropdown: Migrate to v9 + imp
7c2c618 
* Some minor improvements: fix a string, add placeholder support, document variables.
* Acknowledge problem about drag and drop
* Remove example link.
@adr9 @kaynnan
[MIG] website_snippet_country_dropdown: Migration to 10.0
dc34519
@Tardo @kaynnan
[MIG] website_snippet_country_dropdown: Migration to 12.0
1b34316
@ernestotejeda @kaynnan
[IMP] website_snippet_country_dropdown: custom input field classes
5cbd52d 
Allow to set custom classes to input tag with id 'no_country_field'
@kaynnan
[IMP] website_snippet_country_dropdown: readonly mode
1dbd652 
- Remove some garbage code.
- Add readonly mode.
- Add demo data.
- Improve tour.

@Tecnativa TT17694
@claudiagn @kaynnan
Translated using Weblate (Spanish)
4ee0dcb 
Currently translated at 100.0% (9 of 9 strings)

Translation: website-12.0/website-12.0-website_snippet_country_dropdown
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_snippet_country_dropdown/es/
@CarlosRoca13 @kaynnan
[IMP] website_snippet_country_dropdown: black, isort, prettier
5cdd3f2
@CarlosRoca13 @kaynnan
[MIG] website_snippet_country_dropdown: Migration to v13.0
f8663d6
@ernestotejeda @kaynnan
[IMP] website_snippet_country_dropdown: black, isort, prettier
0de1e02
@ernestotejeda @kaynnan
[MIG] website_snippet_country_dropdown: Migration to 14.0
fc26d04
CarlosRoca13 and others added 9 commits February 1, 2024 00:37
@CarlosRoca13 @kaynnan
[MIG] website_snippet_country_dropdown: Migration to 15.0
2c59425
@kaynnan
[UPD] Update website_snippet_country_dropdown.pot
b4a6573
@OCA-git-bot @kaynnan
[UPD] README.rst
0dd07b1
@ioans73 @kaynnan
[FIX] website_snippet_country_dropdown: test-folder-imported
f41f6ca
@mymage @kaynnan
Added translation using Weblate (Italian)
57620a3
@mymage @kaynnan
Translated using Weblate (Italian)
3c78f0d 
Currently translated at 100.0% (9 of 9 strings)

Translation: website-15.0/website-15.0-website_snippet_country_dropdown
Translate-URL: https://translation.odoo-community.org/projects/website-15-0/website-15-0-website_snippet_country_dropdown/it/
@pedrobaeza @kaynnan
[FIX] Update copier template + remove offending en.po
e7d9a31 
To avoid the isort problem (PyCQA/isort#2077)
@kaynnan
[IMP] website_snippet_country_dropdown: black, isort, prettier
6c9e70d
@kaynnan
[MIG] website_snippet_country_dropdown: Migration to 16.0
cf3cac4
@kaynnan kaynnan force-pushed the 16.0-mig-website_snippet_country_dropdown branch from 1acf24a to cf3cac4 Compare February 1, 2024 03:38
@kaynnan
Copy link
Author

kaynnan commented Feb 1, 2024

@pedrobaeza @edlopen

PR updated with rebase on origin/16.0, ready for review

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
pedrobaeza
pedrobaeza approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-986-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6ce41f6 into OCA:16.0 Jun 5, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 00840c7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NICO-SOLUTIONS NICO-SOLUTIONS NICO-SOLUTIONS left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.