-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] website_google_tag_manager: Migration to 16.0 #933
[16.0][MIG] website_google_tag_manager: Migration to 16.0 #933
Conversation
* [ADD] New module 'website_google_tag_manager' * [FIX] website_google_tag_manager - Added OCA as author * [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager') * [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-12.0/website-12.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/
Currently translated at 100.0% (8 of 8 strings) Translation: website-12.0/website-12.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/fr/
Currently translated at 100.0% (8 of 8 strings) Translation: website-12.0/website-12.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/pt_BR/
Currently translated at 100.0% (8 of 8 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/es_AR/
Currently translated at 72.7% (8 of 11 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/fr_FR/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code reviw, LGTM
Hello @flotho , can the pull request be merged now? Thanks |
A second review must be done, and one proceeding from a PSC or maintainer. You can speed this up reviewing other PRs and asking in exchange that they review yours. /ocabot migration website_google_tag_manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM +1
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e6144d1. Thanks a lot for contributing to OCA. ❤️ |
No description provided.