Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_google_tag_manager: Migration to 16.0 #933

Merged

Conversation

bvanjeelharia
Copy link

No description provided.

sebalix and others added 30 commits December 19, 2022 16:34
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/fr/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/pt_BR/
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code reviw, LGTM

@bvanjeelharia
Copy link
Author

Hello @flotho , can the pull request be merged now?

Thanks

@pedrobaeza pedrobaeza changed the title [MIG] website_google_tag_manager: Migration to 16.0 [16.0][MIG] website_google_tag_manager: Migration to 16.0 Jan 2, 2023
@pedrobaeza
Copy link
Member

A second review must be done, and one proceeding from a PSC or maintainer. You can speed this up reviewing other PRs and asking in exchange that they review yours.

/ocabot migration website_google_tag_manager

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 2, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 2, 2023
13 tasks
Copy link

@JrAdhoc JrAdhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM +1

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-933-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1869a91 into OCA:16.0 Jan 11, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e6144d1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.