[MIG] website_search_header: Migration to 17.0 #1070
Conversation
|
Don't lose commit history. |
Hello @pedrobaeza I guess, I did not catch up what you mean. I see the module pull for 16.0 is closed and we are depending on it for the upper versions up to 18.0 I need to share with the author to make the closed pull request succeeds, but I did not understand as I am still new in the community. |
|
Yes, but you have put only one commit, instead of starting from the previous commit history with the initial commit from Jordi, and the rest. This is for preserving the attribution. |
Thanks for clarifications :) |
|
Can I fix the issues in the last commit of version 16.0 and make a pull request for him and through this his pull will be merged, then mine. Or I can just merge this pull if I add the the last commit. |
|
With some git fu, you can keep this PR, rewriting the commit history. Save your current files in another location, reset your last commit, and start getting the commit history using a variation of the command in here: changing the remote to the one of the initial PR. Then, recopy your files and commit the migration itself. |
kobros-tech
force-pushed
the
17.0-mig-website_search_header
branch
from
e7c5835
to
9402b07
Compare
kobros-tech
force-pushed
the
17.0-mig-website_search_header
branch
from
9402b07
to
8729a0c
Compare
|
@kobros-tech is this module really necessary? In version 17.0 we already have a default website search
|
|
I just put it to refer and it is now deprecated after the PR of my boss, #1071 |
This module is upgraded from the pull #1000 of version 16.0 but is closed.
I don't know why it is not merged, but I make this pull to share the upgraded version if someone needs it.
I have made modifications on the module in JavaScript, if possible we cooperate again and modify the 16.0 version and try to merge it again.
I looking forward to hearing from you...
@JordiBForgeFlow
@ioans73
@pedrobaeza
ets/2606e76c-059e-4ea5-a382-3b972b2c6c2c)