Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] website_form_require_legal: Migration to 17.0 #1020

Merged
merged 10 commits into from
Aug 22, 2024
Merged

[17.0][MIG] website_form_require_legal: Migration to 17.0 #1020

merged 10 commits into from
Aug 22, 2024

Conversation

NICO-SOLUTIONS
Copy link
Member

Standard MIgration to 17.0

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review November 20, 2023 20:04
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Nov 20, 2023
Open
13 tasks
@pedrobaeza
Copy link
Member

Please do the changes of the version in the migration commit, not in the pre-commit one

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-website_form_require_legal branch from 8fc6874 to 34b46c5 Compare November 21, 2023 13:18
@NICO-SOLUTIONS
Copy link
Member Author

Please do the changes of the version in the migration commit, not in the pre-commit one

@pedrobaeza Yes of Course. Sorry and thanks for the hint! Done.

@pedrobaeza
Copy link
Member

/ocabot migration website_form_require_legal

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 21, 2023
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-website_form_require_legal branch from 34b46c5 to fe6a184 Compare January 11, 2024 22:17
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-website_form_require_legal branch from fe6a184 to 7d2d697 Compare March 23, 2024 14:03
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-website_form_require_legal branch from 7d2d697 to a105664 Compare May 16, 2024 14:27
Anxo82
Anxo82 approved these changes Jun 17, 2024
View reviewed changes
Copy link

@Anxo82 Anxo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally test 👍

ChristianSantamaria
ChristianSantamaria approved these changes Aug 22, 2024
View reviewed changes
Copy link

@ChristianSantamaria ChristianSantamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

Can you please rebase to get a functional runboat?

CarlosRoca13 and others added 10 commits August 22, 2024 11:02
@CarlosRoca13 @NICO-SOLUTIONS
[ADD] website_form_require_legal: New module to add terms acceptance …
78f651a 
…at website form level
@NICO-SOLUTIONS
[UPD] Update website_form_require_legal.pot
38d7721
@OCA-git-bot @NICO-SOLUTIONS
[UPD] README.rst
9881c03
@OCA-git-bot @NICO-SOLUTIONS
[ADD] icon.png
778dd15
@NICO-SOLUTIONS
Added translation using Weblate (German)
c9b75ec
@NICO-SOLUTIONS
Translated using Weblate (German)
a1abf9d 
Currently translated at 100.0% (4 of 4 strings)

Translation: website-15.0/website-15.0-website_form_require_legal
Translate-URL: https://translation.odoo-community.org/projects/website-15-0/website-15-0-website_form_require_legal/de/
@pilarvargas-tecnativa @NICO-SOLUTIONS
[MIG] website_form_require_legal: Migration to version 16.0
559d2ac 
TT44376

[UPD] Update website_form_require_legal.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_form_require_legal
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_form_require_legal/
@mymage @NICO-SOLUTIONS
Added translation using Weblate (Italian)
f951af5 
Translated using Weblate (Italian)

Currently translated at 100.0% (4 of 4 strings)

Translation: website-16.0/website-16.0-website_form_require_legal
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_form_require_legal/it/
@NICO-SOLUTIONS
[IMP] website_form_require_legal: pre-commit auto fixes
e79a374
@NICO-SOLUTIONS
[MIG] website_form_require_legal: Migration to 17.0
e029f05
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-website_form_require_legal branch from a105664 to e029f05 Compare August 22, 2024 09:03
@NICO-SOLUTIONS
Copy link
Member Author

Can you please rebase to get a functional runboat?

@pedrobaeza done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested in runboat

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1020-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fdd7ff2 into OCA:17.0 Aug 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a8624be. Thanks a lot for contributing to OCA. ❤️

@NICO-SOLUTIONS NICO-SOLUTIONS deleted the 17.0-mig-website_form_require_legal branch August 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anxo82 Anxo82 Anxo82 approved these changes

@ChristianSantamaria ChristianSantamaria ChristianSantamaria approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@NICO-SOLUTIONS @pedrobaeza @OCA-git-bot @ChristianSantamaria @Anxo82 @CarlosRoca13 @pilarvargas-tecnativa @mymage