Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] website_snippet_big_button: default links #1008

Merged

Conversation

pilarvargas-tecnativa
Copy link

Default links should not be set so that a user can edit where each button should redirect to so that in case of not editing the link there are no default redirects.

cc @Tecnativa TT41033

@chienandalu @CarlosRoca13 please review :)

Default links should not be set so that a user can edit where each
button should redirect to so that in case of not editing the link
there are no default redirects.

TT41033
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 4, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1008-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c604baf into OCA:15.0 Sep 4, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-1008-by-pedrobaeza-bump-minor:15.0 failed with output:

To https://github.com/OCA/website
 ! [rejected]          15.0-ocabot-merge-pr-1008-by-pedrobaeza-bump-minor -> 15.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/website'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b328a47. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants