-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] stock_reserve_rule: add full bin strategy #1831
[14.0][IMP] stock_reserve_rule: add full bin strategy #1831
Conversation
The full empty bin rule is like the empty bin rule, but it should take everything. That means there can not be any pre existing reservations.
0c30a35
to
57dec64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
@jbaudoux can i have more details about this PR ? |
This is to prefer a location where the move takes everything from it. Useful for locations with everything on single pallet. Then you know you can take the full pallet. |
Hi @jbaudoux i’m testing this PR in the runboat.
Then i have installed sale app and i followed these steps:
What i’m aspecting that user get the location “My location for test” but actually he gets only product unreserved. |
@elvise You put 2 products on the location and you try to reserve only one of them, so you are not reserving the full location. So works as expected. Thanks for the test. |
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
@jbaudoux My pleasure 🤟🏻 |
Congratulations, your PR was merged at c03c953. Thanks a lot for contributing to OCA. ❤️ |
The full empty bin rule is like the empty bin rule, but it should take everything. That means there can not be any pre existing reservations.
ref.: rau-206