Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] stock_reserve_rule: add full bin strategy #1831

Merged

Conversation

TDu
Copy link
Member

@TDu TDu commented Sep 6, 2023

The full empty bin rule is like the empty bin rule, but it should take everything. That means there can not be any pre existing reservations.

ref.: rau-206

The full empty bin rule is like the empty bin rule, but it should take
everything. That means there can not be any pre existing reservations.
@TDu TDu force-pushed the 14-reserve-rule-add-full-empty-bin branch from 0c30a35 to 57dec64 Compare September 13, 2023 07:01
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jbaudoux jbaudoux changed the title [14.0][IMP] stock_reserve_rule: add full empty bin removal strategy [14.0][IMP] stock_reserve_rule: add full bin strategy Sep 19, 2023
@elvise
Copy link

elvise commented Sep 19, 2023

@jbaudoux can i have more details about this PR ?

@jbaudoux
Copy link
Contributor

@jbaudoux can i have more details about this PR ?

This is to prefer a location where the move takes everything from it. Useful for locations with everything on single pallet. Then you know you can take the full pallet.

@elvise
Copy link

elvise commented Sep 25, 2023

@jbaudoux can i have more details about this PR ?

This is to prefer a location where the move takes everything from it. Useful for locations with everything on single pallet. Then you know you can take the full pallet.

Hi @jbaudoux i’m testing this PR in the runboat.
i created:

  • Product: my test
  • Location: My location for test (wh/stock/mylocationfortest)
  • Reservation rule: Test 1
    IMG_0970

IMG_0971

  • Created an inventory for “my test” product

  • Location: Shelf 1 > 10 units for “my test” and 10 units for “Bolt-White”
    IMG_0967

  • Location: My location for test > 10 units for “my test”
    IMG_0966

Then i have installed sale app and i followed these steps:

  • Create new SO with product “my test”
  • Confirm SO
  • Opened related picking

What i’m aspecting that user get the location “My location for test” but actually he gets only product unreserved.
IMG_0968

IMG_0969

@francesco-ooops
Copy link
Contributor

@jbaudoux any feedback on @elvise 's functional test?

@rousseldenis rousseldenis added this to the 14.0 milestone Oct 26, 2023
@jbaudoux
Copy link
Contributor

jbaudoux commented Nov 9, 2023

@elvise You put 2 products on the location and you try to reserve only one of them, so you are not reserving the full location. So works as expected. Thanks for the test.

@jbaudoux
Copy link
Contributor

jbaudoux commented Nov 9, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1831-by-jbaudoux-bump-minor, awaiting test results.

@elvise
Copy link

elvise commented Nov 9, 2023

@jbaudoux My pleasure 🤟🏻

@OCA-git-bot OCA-git-bot merged commit 1b7e6e4 into OCA:14.0 Nov 9, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c03c953. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants