-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] date_range: Generate new stable version #2486
base: 10.0
Are you sure you want to change the base?
Conversation
Hi @lmignon, |
0f1e108
to
06cad4e
Compare
06cad4e
to
69df5e5
Compare
7f7dcd6
to
146e8b9
Compare
6a4bbe1
to
3135a4c
Compare
@@ -5,6 +5,8 @@ | |||
"name": "LDAP Populate", | |||
"version": "10.0.1.0.3", | |||
"author": "Therp BV, Odoo Community Association (OCA)", | |||
"website": "https://github.com/OCA/server-tools" | |||
"/tree/10.0/users_ldap_populate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are website urls are unusual. Did you make them manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look!
Yes I did them manually (with a script) because I like the website of a module to point to the module's information instead of the repository's information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but you are actually exploiting a bug in the linter so it may break in the future. If you want that it's better to work to have the feature in the official repo template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but you are actually exploiting a bug in the linter so it may break in the future. If you want that it's better to work to have the feature in the official repo template.
😅 I thought it was allowed on purpose, since this kind of URL is accepted by the guidelines:
The website key must be https://github.com/OCA/<repo>, so as to provide the most relevant link to discover more information about the addon. That link shows the repository README. Alternatively https://github.com/OCA//tree//<addon> may be used, to provide a direct link to the addon README, which includes proper credits (authors, contributors and theirs companies), and links to the relevant information on the OCA website.
Set running_env for server_environment Install deb packages
c0e09cf
to
888e873
Compare
I'm having trouble with Github actions for
10.0
: in https://github.com/OCA/l10n-italy/actions/runs/3603460390/jobs/6071687725#step:4:50 it is choosing a very old release (10.0.1.0.2) of module date_range.I have found out that in https://wheelhouse.odoo-community.org/oca-simple/odoo10-addon-date-range/ (as well as https://pypi.org/project/odoo10-addon-date-range/) 10.0.1.0.2 is the most recent stable version, so maybe that is the reason.
Hoping this PR creates a new stable version.