Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] date_range: Generate new stable version #2486

Open
wants to merge 14 commits into
base: 10.0
Choose a base branch
from

Conversation

SirTakobi
Copy link

I'm having trouble with Github actions for 10.0: in https://github.com/OCA/l10n-italy/actions/runs/3603460390/jobs/6071687725#step:4:50 it is choosing a very old release (10.0.1.0.2) of module date_range.

I have found out that in https://wheelhouse.odoo-community.org/oca-simple/odoo10-addon-date-range/ (as well as https://pypi.org/project/odoo10-addon-date-range/) 10.0.1.0.2 is the most recent stable version, so maybe that is the reason.
Hoping this PR creates a new stable version.

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@SirTakobi SirTakobi force-pushed the 10.0-date_range-new_wheel branch 2 times, most recently from 0f1e108 to 06cad4e Compare December 21, 2022 10:56
@SirTakobi SirTakobi marked this pull request as draft December 21, 2022 11:16
@SirTakobi SirTakobi force-pushed the 10.0-date_range-new_wheel branch from 06cad4e to 69df5e5 Compare December 21, 2022 12:33
@SirTakobi SirTakobi force-pushed the 10.0-date_range-new_wheel branch 8 times, most recently from 7f7dcd6 to 146e8b9 Compare January 12, 2023 12:25
@SirTakobi SirTakobi force-pushed the 10.0-date_range-new_wheel branch 2 times, most recently from 6a4bbe1 to 3135a4c Compare January 23, 2023 15:58
@@ -5,6 +5,8 @@
"name": "LDAP Populate",
"version": "10.0.1.0.3",
"author": "Therp BV, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/server-tools"
"/tree/10.0/users_ldap_populate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are website urls are unusual. Did you make them manually?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look!
Yes I did them manually (with a script) because I like the website of a module to point to the module's information instead of the repository's information

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but you are actually exploiting a bug in the linter so it may break in the future. If you want that it's better to work to have the feature in the official repo template.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but you are actually exploiting a bug in the linter so it may break in the future. If you want that it's better to work to have the feature in the official repo template.

😅 I thought it was allowed on purpose, since this kind of URL is accepted by the guidelines:

The website key must be https://github.com/OCA/<repo>, so as to provide the most relevant link to discover more information about the addon. That link shows the repository README. Alternatively https://github.com/OCA//tree//<addon> may be used, to provide a direct link to the addon README, which includes proper credits (authors, contributors and theirs companies), and links to the relevant information on the OCA website.

(from https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#11modules)

@SirTakobi SirTakobi force-pushed the 10.0-date_range-new_wheel branch from c0e09cf to 888e873 Compare January 24, 2023 14:09
@SirTakobi SirTakobi marked this pull request as ready for review January 24, 2023 14:19
@SirTakobi SirTakobi requested a review from sbidoul March 23, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants