-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] server_environment from 17.0 #204
Conversation
@moylop260 can you help with the |
The other issue is that the current |
Currently on it. Try regenerating .pot file. |
Try including SirAionTech@d8e1926; I'll try to include it in the addons repo template in the next few days or more probably after the experience |
@SirAionTech I worry that this adds additional dependencies that are not pinned. I don't know, if we don't find a good solution soon, we'll start with the same eslint version as in 17. And we then have a year to modernize.. |
(lp:c2c-addons/6.1 rev 11)
(lp:c2c-addons/6.1 rev 11.1.4)
(lp:c2c-addons/6.1 rev 28.1.1)
…t is the blessed target. (lp:c2c-addons/6.1 rev 40.2.1)
(lp:c2c-addons/6.1 rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target. (lp:c2c-addons/6.1 rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems lsb_release outputs to stderr as well as stdout. This message will be printed to console, not logged nor shown among server infomation. That way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Revert "server_environment: Fix value assignation in compute from default" This reverts commit 464f3ec which would break other modules using server_environment. The original issue must be fixed in mail_environment.
c3b2f7a
to
e5218e6
Compare
🍏 |
Don't merge just yet, I need to restart the bot. |
Ok, bot is ready. |
Checking... |
It needs the following args in order to autofix it: - repo: https://github.com/OCA/odoo-pre-commit-hooks
rev: v0.0.33
hooks:
- id: oca-checks-odoo-module
- id: oca-checks-po
+ args:
+ - --fix OFFTOPIC: BTW I will show the diff if the parameter is not defined for wrong-format UPDATED: OCA/odoo-pre-commit-hooks#110 UPDATED2: Agree disabling it OCA/oca-addons-repo-template#274 |
e5218e6
to
8aa5fbb
Compare
/ocabot migration server_environment |
There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment. |
The pre-commit auto-fixes commit is after the migration commit, but not being critical, let's try to merge the module to see if any problem: /ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 3ddab30. Thanks a lot for contributing to OCA. ❤️ |
First 18.0 PR to test the project template.
the xml prettifier improvements: Improve xml prettyfier oca-addons-repo-template#224