Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] jobrunner cli #409

Merged
merged 1 commit into from
Apr 29, 2022
Merged

[RFC] jobrunner cli #409

merged 1 commit into from
Apr 29, 2022

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Feb 17, 2022

/!\ This is very rough and mostly untested. So just an idea so far.

I wonder if running the job runner in a standalone process could be a solution to the problem of running a single job runner in a multi-node deployment.

We could then let the responsibility of running one replica of the job runner to the orchestrator (say, k8s), and we don't need ensure it's a singleton ourselves.

Use with env ODOO_RC=odoo.cfg python -m odoo.addons.queue_job.jobrunner.

@sbidoul
Copy link
Member Author

sbidoul commented Feb 17, 2022

With this, there is no need for queue_job in server_wide_modules.

@sbidoul sbidoul force-pushed the 14.0-jobrunner-cli-sbi branch from ef61552 to f415ec6 Compare April 14, 2022 09:05
@sbidoul sbidoul marked this pull request as ready for review April 14, 2022 09:06
@sbidoul
Copy link
Member Author

sbidoul commented Apr 14, 2022

This seems to work well in our first tests. I think we can merge this as it is non-intrusive. I'll document it when we have more experience in production.

Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good indeed for k8s-style infrastructure. Thanks!
We've run full loop with the old odoo-job-runner start script (don't remember the exact name) 😆

@guewen
Copy link
Member

guewen commented Apr 29, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-409-by-guewen-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 07bf2ec into OCA:14.0 Apr 29, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dab2bcb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants